The nodejs client should pass the project name in the `user` querystring param

RESOLVED FIXED

Status

Tree Management
Treeherder: Client Libraries
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mdoglio, Assigned: mdoglio)

Tracking

Details

Attachments

(1 attachment)

49 bytes, text/x-github-pull-request
garndt
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
We should change the node client to report the project/repository in the user parameter.
At the moment it's using `treeherder-node 0.5.0`.
We should move the client identification string to the user agent header (bug 1186918) and use the project/repository name instead.

Comment 1

3 years ago
When we fix this (and users of the nodejs client have all updated), I guess we can remove the workaround added in the 2nd landing of bug 1185520.
Blocks: 1185520
(Assignee)

Comment 2

3 years ago
Created attachment 8643675 [details] [review]
PR 5
Assignee: nobody → mdoglio
Attachment #8643675 - Flags: review?(garndt)

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-node

https://github.com/mozilla/treeherder-node/commit/934396c4a9153823c6cb31f483561eba0a5efff0
Bug 1191252 - oauth user default to project name

https://github.com/mozilla/treeherder-node/commit/8415e976546c6813be40dc5f0539e018734cc093
Merge pull request #5 from mozilla/bug-1191252-oauth-user

Bug 1191252 - oauth user default to project name

Comment 4

3 years ago
Comment on attachment 8643675 [details] [review]
PR 5

LGTM.  I also pushed a change that will fix that failing travis test. https://github.com/mozilla/treeherder-node/commit/8415e976546c6813be40dc5f0539e018734cc093
Attachment #8643675 - Flags: review?(garndt) → review+

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.