Closed Bug 1191252 Opened 9 years ago Closed 9 years ago

The nodejs client should pass the project name in the `user` querystring param

Categories

(Tree Management Graveyard :: Treeherder: Client Libraries, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mdoglio, Assigned: mdoglio)

References

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
garndt
: review+
Details | Review
We should change the node client to report the project/repository in the user parameter.
At the moment it's using `treeherder-node 0.5.0`.
We should move the client identification string to the user agent header (bug 1186918) and use the project/repository name instead.
When we fix this (and users of the nodejs client have all updated), I guess we can remove the workaround added in the 2nd landing of bug 1185520.
Blocks: 1185520
Attached file PR 5
Assignee: nobody → mdoglio
Attachment #8643675 - Flags: review?(garndt)
Comment on attachment 8643675 [details] [review]
PR 5

LGTM.  I also pushed a change that will fix that failing travis test. https://github.com/mozilla/treeherder-node/commit/8415e976546c6813be40dc5f0539e018734cc093
Attachment #8643675 - Flags: review?(garndt) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: