1185558 - Implement "Service-Worker/script" header

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

We need to implement step 4.6 to send "Service-Worker/script" header on the request:

  https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#update-algorithm

Comment 1

[(no longer active)]

Attachment: Send a "Service-Worker: script" header when downloading service worker scripts

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8677098 [details] [diff] [review]
Send a "Service-Worker: script" header when downloading service worker scripts

Review of attachment 8677098 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerScriptCache.cpp
@@ +140,5 @@
>      if (httpChannel) {
>        // Spec says no redirects allowed for SW scripts.
>        httpChannel->SetRedirectionLimit(0);
> +
> +      httpChannel->SetRequestHeader(NS_LITERAL_CSTRING("Service-Worker"), NS_LITERAL_CSTRING("script"), false);

nit: Line length and please include a /* merge */ comment on the bare boolean.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da5aa8844048

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da5aa8844048