1185637 - remove a few more DEFINES from Makefile.ins

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - move APP_VERSION defines into moz.build

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - move DEFINES out of browser/installer/windows/Makefile.in

I think we ought to be able to use MOZILLA_VERSION_U here instead of adding our
own define for MOZILLA_VERSION, but I will defer that to a later patch.
(Thought maybe it will need to be done in this patch, since ACDEFINES already
defines MOZILLA_VERSION...?)

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8636139 [details] [diff] [review]
part 2 - move DEFINES out of browser/installer/windows/Makefile.in

Review of attachment 8636139 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/installer/windows/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  DEFINES['APP_VERSION'] = CONFIG['FIREFOX_VERSION']
> +

why the empty line?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e41d50d98502
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdfaafcf994b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e41d50d98502
https://hg.mozilla.org/mozilla-central/rev/bdfaafcf994b