Remove media.windows-media-foundation.enabled pref

RESOLVED FIXED in Firefox 42

Status

()

Core
Audio/Video
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We're seeing MediaSource.addSourceBuffer() fail on Netflix.com with valid input. 

This could happen if Windows Media Foundation is disabled via media.windows-media-foundation.enabled pref. We don't really need that pref anymore, since playback can be disabled by the media.fragmented-mp4 prefs.

We should remove the media.windows-media-foundation.enabled pref, as it's redundant, and we suspect it's causing Netflix to fail.

STR:
1. Set media.windows-media-foundation.enabled to false.
2. Load Netflix video.

Expected result:
Netflix video plays.

Observed result:
Netflix displays a F7355 error.

As an aside, I think users do this to prevent Firefox from loading the videos opened in a VideoDocument. Our pref to control that isn't working, I filed bug 1185730 for that.
(Assignee)

Comment 1

3 years ago
Created attachment 8636345 [details] [diff] [review]
Patch: Remove WMF toggle pref

Remove WMF toggle pref; now the media.fragmented* and media-format-reader.mp4 prefs handle this.
Attachment #8636345 - Flags: review?(jyavenard)
Comment on attachment 8636345 [details] [diff] [review]
Patch: Remove WMF toggle pref

Review of attachment 8636345 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/test_can_play_type_mpeg.html
@@ +141,2 @@
>  // TODO:  Add "getPref("media.plugins.enabled")" once MP4 works on Gingerbread.
>               

I think if you removed the existing trailing spaces, no one would say anything :)
Attachment #8636345 - Flags: review?(jyavenard) → review+
https://hg.mozilla.org/mozilla-central/rev/b647f4f166d6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Comment 5

3 years ago
Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=588abc33bda3

Aurora try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d07b822046b

STR in comment #0.

I have verified that this patch fixes the issue in Nightly using STR from comment #0.
Flags: needinfo?(cpearce)
(Assignee)

Comment 7

3 years ago
After thinking about it, I don't think we need to uplift this. Netflix should be checking canPlayType, rather than assuming the user hasn't preffed off something required in Firefox.
Flags: needinfo?(cpearce)
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.