1185782 - Remove media.windows-media-foundation.enabled pref

Status: RESOLVED FIXED

Description

[Chris Pearce (:cpearce)]

We're seeing MediaSource.addSourceBuffer() fail on Netflix.com with valid input. 

This could happen if Windows Media Foundation is disabled via media.windows-media-foundation.enabled pref. We don't really need that pref anymore, since playback can be disabled by the media.fragmented-mp4 prefs.

We should remove the media.windows-media-foundation.enabled pref, as it's redundant, and we suspect it's causing Netflix to fail.

STR:
1. Set media.windows-media-foundation.enabled to false.
2. Load Netflix video.

Expected result:
Netflix video plays.

Observed result:
Netflix displays a F7355 error.

As an aside, I think users do this to prevent Firefox from loading the videos opened in a VideoDocument. Our pref to control that isn't working, I filed bug 1185730 for that.

Comment 1

[Chris Pearce (:cpearce)]

Created attachment 8636345 [details] [diff] [review]
Patch: Remove WMF toggle pref

Remove WMF toggle pref; now the media.fragmented* and media-format-reader.mp4 prefs handle this.

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8636345 [details] [diff] [review]
Patch: Remove WMF toggle pref

Review of attachment 8636345 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/test_can_play_type_mpeg.html
@@ +141,2 @@
>  // TODO:  Add "getPref("media.plugins.enabled")" once MP4 works on Gingerbread.
>               

I think if you removed the existing trailing spaces, no one would say anything :)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b647f4f166d6

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b647f4f166d6

Comment 5

[Chris Pearce (:cpearce)]

Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=588abc33bda3

Aurora try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d07b822046b

STR in comment #0.

I have verified that this patch fixes the issue in Nightly using STR from comment #0.

Comment 6

[Chris Pearce (:cpearce)]

Beta try push that builds:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7645c670e21b

Comment 7

[Chris Pearce (:cpearce)]

After thinking about it, I don't think we need to uplift this. Netflix should be checking canPlayType, rather than assuming the user hasn't preffed off something required in Firefox.