Closed Bug 1185802 Opened 10 years ago Closed 10 years ago

B2G RIL: support fota apn type

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2r+, firefox42 fixed, b2g-v2.2 wontfix, b2g-v2.2r fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S3 (24Jul)
Project Flags:
feature-b2g 2.2r+
Tracking Flags:
Tracking Status
firefox42 --- fixed
b2g-v2.2 --- wontfix
b2g-v2.2r --- fixed
b2g-master --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

Attachments

(6 files, 3 obsolete files)

Part 1: idl changes. r=hsinyi
3.83 KB, patch
jessica
: review+
Details | Diff | Splinter Review
Part 2: impl, v2.
8.44 KB, patch
hsinyi
: review+
Details | Diff | Splinter Review
Part 3: test changes. r=hsinyi
5.38 KB, patch
jessica
: review+
Details | Diff | Splinter Review
[v2.2r] Part 1: idl changes.
3.65 KB, patch
Details | Diff | Splinter Review
[v2.2r] Part 2: impl.
7.01 KB, patch
Details | Diff | Splinter Review
[v2.2r] Part 3: tests.
5.34 KB, patch
Details | Diff | Splinter Review
fota apn is needed for connecting to update server (FOTA), in order to check for update and downloading update package. See Bug 1179097 comment 11.
Attached patch Part 1: idl changes, v1. (obsolete) — — Splinter Review
Assignee: nobody → jjong
Attached patch Part 2: impl, v1. (obsolete) — — Splinter Review
Attachment #8636483 - Attachment description: Part 1: idl changes. → Part 1: idl changes, v1.
Attached patch Part 3: tests, v1. (obsolete) — — Splinter Review
Comment on attachment 8636483 [details] [diff] [review] Part 1: idl changes, v1. Hsinyi, would you mind reviewing this? Thanks.
Attachment #8636483 - Flags: review?(htsai)
Attachment #8636485 - Flags: review?(htsai)
Attachment #8636486 - Flags: review?(htsai)
Attachment #8636483 - Flags: review?(htsai) → review+
Comment on attachment 8636485 [details] [diff] [review] Part 2: impl, v1. Review of attachment 8636485 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/NetworkManager.js @@ +227,5 @@ > let excludeMms = aMsg.json.excludeMms; > let excludeSupl = aMsg.json.excludeSupl; > let excludeIms = aMsg.json.excludeIms; > let excludeDun = aMsg.json.excludeDun; > + let excludeFota = aMsg.json.excludeFota; Looks the definition of .json.excludeFota is missing. See https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkInterfaceListService.js?from=networkinterfacelistservice.js#31 We need to modify other NetworkInterfaceListService related code as well, e.g. [1] [1] https://dxr.mozilla.org/mozilla-central/source/media/mtransport/gonk_addrs.cpp?from=gonk_addrs.cpp&case=true#47 [2] https://dxr.mozilla.org/mozilla-central/source/dom/media/tests/mochitest/network.js#22
Attachment #8636485 - Flags: review?(htsai)
Attachment #8636486 - Flags: review?(htsai) → review+
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #5) > Comment on attachment 8636485 [details] [diff] [review] > Part 2: impl, v1. > > Review of attachment 8636485 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/system/gonk/NetworkManager.js > @@ +227,5 @@ > > let excludeMms = aMsg.json.excludeMms; > > let excludeSupl = aMsg.json.excludeSupl; > > let excludeIms = aMsg.json.excludeIms; > > let excludeDun = aMsg.json.excludeDun; > > + let excludeFota = aMsg.json.excludeFota; > > Looks the definition of .json.excludeFota is missing. See > https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ > NetworkInterfaceListService.js?from=networkinterfacelistservice.js#31 > > We need to modify other NetworkInterfaceListService related code as well, > e.g. [1] > > [1] > https://dxr.mozilla.org/mozilla-central/source/media/mtransport/gonk_addrs. > cpp?from=gonk_addrs.cpp&case=true#47 > [2] > https://dxr.mozilla.org/mozilla-central/source/dom/media/tests/mochitest/ > network.js#22 Right, I missed this. Will upload a new version to fix it, thanks!
Move nsINetworkInterfaceListService changes to this part, and add r=hsinyi.
Attachment #8636483 - Attachment is obsolete: true
Attachment #8637779 - Flags: review+
Hsinyi, I've addressed review comment 5, could you help review again? Note that I have put idl chanegs in part 1 and test changes in part 3. Thanks!
Attachment #8636485 - Attachment is obsolete: true
Attachment #8637786 - Flags: review?(htsai)
Include media network.js changes and add r=hsinyi.
Attachment #8636486 - Attachment is obsolete: true
Attachment #8637789 - Flags: review+
Comment on attachment 8637786 [details] [diff] [review] Part 2: impl, v2. Review of attachment 8637786 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8637786 - Flags: review?(htsai) → review+
This is required by Red-Tai.
blocking-b2g: --- → 2.2r?
ni myself to follow up.
Flags: needinfo?(whuang)
We'll need it to make the API in bug 1179097 complete. Please uplift to 2.2r
Blocks: 1179097
blocking-b2g: 2.2r? → ---
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
Needs rebasing for v2.2r uplift.
status-b2g-v2.2: --- → wontfix
status-b2g-master: --- → fixed
Flags: needinfo?(jjong)
Target Milestone: --- → FxOS-S3 (24Jul)
In v2.2r, data call related stuff have not moved out from RadioInterfaceLayer yet (see bug 1114901), so the the files we need to modify are different. I'll provide patches for v2.2r, keeping NI for tracking.
See Also: → 1185805
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #17) > Needs rebasing for v2.2r uplift. Patches for v2.2r are ready. Could you help uplift them? Thanks.
Flags: needinfo?(jjong) → needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: