1185805 - APN Settings: parse fota apn type from apn database

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jessica Jong [:jessica] (inactive)]

APNs for fota need to be parsed from the apn database and passed to gecko through 'ril.data.apnSettings', just like the other apn types.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Thank you José for taking this, I was just wondering whose help to ask. :)

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #1)
> Thank you José for taking this, I was just wondering whose help to ask. :)

Jessica, is there any plan about when this should be landed? Is this something like a 2.5 blocker? Thanks!

Comment 3

[Jessica Jong [:jessica] (inactive)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> (In reply to Jessica Jong [:jjong] [:jessica] from comment #1)
> > Thank you José for taking this, I was just wondering whose help to ask. :)
> 
> Jessica, is there any plan about when this should be landed? Is this
> something like a 2.5 blocker? Thanks!

José, this should be landed on master and uplifted to v2.2r. It's needed by partner, so I think it's a blocker for v2.2r. Thanks.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

feature-b2g:2.2r+ as it's requested by Red-Tai.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] jaoo:1185805 > mozilla-b2g:master

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8649307 [details] [review]
[gaia] jaoo:1185805 > mozilla-b2g:master

Jessica, do you mind to give this a try and let me know how that works please? I've tried by mocking the mcc and mnc codes (mcc/mnc '208'/'09' because it has a FOTA APN) from the ICC card in my device and it seems the FOTA APN reaches RIL plumbing correctly. Thanks!

Comment 7

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8649307 [details] [review]
[gaia] jaoo:1185805 > mozilla-b2g:master

José, works for me too by tweaking the apns for me ICC card. Thanks!

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8649307 [details] [review]
[gaia] jaoo:1185805 > mozilla-b2g:master

Evelyn, would you mind to review this please? Thanks!

Comment 9

[Evelyn Hung]

Comment on attachment 8649307 [details] [review]
[gaia] jaoo:1185805 > mozilla-b2g:master

:jaoo, I took a look of this patch and it's good. Since nobody knows APN than you and Jessica tested it so I just rubberstamp r+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Gaia Try run has real-looking failures AFAICT.
https://treeherder.mozilla.org/logviewer.html#?job_id=1923676&repo=gaia

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> Gaia Try run has real-looking failures AFAICT.
> https://treeherder.mozilla.org/logviewer.html#?job_id=1923676&repo=gaia

Hmm, I've just triggered the job. The failures are about the keyboard app so completely unrelated if I am not wrong.

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Everything looks good now, lets land this please.

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8fc7b07dcff735b1ec8821fc3e63462720f55fcb

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/0a8f66e0c415815c93edc355b584d7492f9c7e8b

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2r: https://github.com/mozilla-b2g/gaia/commit/84e4fe9f80586b706d4e3f655b4ba6b171729052