1185836 - Replace a bunch of EnumerateRead in ActorsParent

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This isn't all of it, but its a good chunk.

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8636441 [details] [diff] [review]
Patch

Review of attachment 8636441 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/ActorsParent.cpp
@@ +11730,2 @@
>  
> +  for (auto iter = mObjectStores.ConstIter(); !iter.Done(); iter.Next()) {

can we split this in some static function? We have 2 nested for loops.

Comment 2

[Nicholas Nethercote [inactive]]

What's wrong with nested loops?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah I don't see anything wrong with nested loops here.  Pushed as is.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2622250e83c9

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7729f8422fb7

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d2034ff3816

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2622250e83c9
https://hg.mozilla.org/mozilla-central/rev/7729f8422fb7
https://hg.mozilla.org/mozilla-central/rev/1d2034ff3816