Closed Bug 1181444 (replace-nsBaseHashtable-Enumerate) Opened 9 years ago Closed 8 years ago

Replace nsBaseHashtable::Enumerate{Read,}() with an iterator

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(3 files)

(part 1) - Remove nsBaseHashtable::EnumerateRead()
10.16 KB, patch
froydnj
: review+
n.nethercote
: checkin+
Details | Diff | Splinter Review
(part 1.5) - Remove dead PLDHashOperator declarations
8.15 KB, patch
froydnj
: review+
n.nethercote
: checkin+
Details | Diff | Splinter Review
(part 2) - Remove nsBaseHashtable::Enumerate()
8.04 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Iterators are *so* much nicer than Enumerate()-style functions -- no need for a separate function, no need to bundle up relevant local variables into a |void*| closure, etc.

Currently there are about 229 calls to nsBaseHashtable::EnumerateRead() and about 143 calls to nsBaseHashtable::Enumerate(), so this is going to take a while.
Alias: replace-nsBaseHashtable-Enumerate
Depends on: 1181445
Depends on: 1182408
Depends on: 1182725
No longer depends on: 1182725
No longer depends on: 1182408
Depends on: 1184432
Depends on: 1185836
Depends on: 1186783
Depends on: 1186785
Depends on: 1186786
Depends on: 1186787
Depends on: 1186790
Depends on: 1186791
Depends on: 1186792
Depends on: 1186793
Depends on: 1186794
Depends on: 1186795
Depends on: 1186796
Depends on: 1186805
Depends on: 1186806
Depends on: 1186808
Depends on: 1186809
Depends on: 1186810
Depends on: 1186811
Depends on: 1186812
Depends on: 1186813
Depends on: 1186814
Depends on: 1186815
Depends on: 1186817
Depends on: 1187114
Depends on: 1187115
Depends on: 1187116
Depends on: 1187134
Depends on: 1187137
Depends on: 1187138
Depends on: 1187139
Depends on: 1187141
Depends on: 1187142
Depends on: 1187144
Depends on: 1187145
Depends on: 1187146
Depends on: 1187149
Depends on: 1187151
Depends on: 1187152
Assignee: n.nethercote → nobody
Status: ASSIGNED → NEW
Depends on: 1187188
Depends on: 1187781
Depends on: 1187782
Depends on: 1187784
Depends on: 1225407
Keywords: leave-open
This is almost ready to land. Only a couple more blocking bugs, all of which
have patches filed.
Attachment #8690615 - Flags: review?(nfroyd)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Depends on: 1227010
Depends on: 1227020
Comment on attachment 8690615 [details] [diff] [review]
(part 1) - Remove nsBaseHashtable::EnumerateRead()

Review of attachment 8690615 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray!
Attachment #8690615 - Flags: review?(nfroyd) → review+
Attachment #8690615 - Flags: checkin+
EnumerateRead() is now gone. Enumerate() still remains, though weaker than before.
Depends on: 1229073
Attachment #8713444 - Flags: review?(nfroyd) → review+
Comment on attachment 8713450 [details] [diff] [review]
(part 2) - Remove nsBaseHashtable::Enumerate()

Review of attachment 8713450 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8713450 - Flags: review?(nfroyd) → review+
Attachment #8713444 - Flags: checkin+
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 1247093
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: