Closed Bug 1185852 Opened 6 years ago Closed 6 years ago

sentry.pl should exit early if there aren't any reports to send

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

Details

sentry.pl currently always builds the header.  it would be slightly more efficient to build it only if there are files to send.
there's actual measurable gains to be had by not loading the bugzilla stack if there aren't any files to send.  thankfully bugzilla::constants doesn't 'use bugzilla', so it's very cheap.

here's the before/after timings:

/opt/bugzilla/htdocs/1185852$ time ./sentry.pl
real	0m0.712s
user	0m0.658s
sys	0m0.055s

/opt/bugzilla/htdocs/1185852$ time ./sentry.pl
real	0m0.027s
user	0m0.026s
sys	0m0.001s

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   ec9b5fd..19cfefe  master -> master
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Summary: sentry.pl should build lazily build the head → sentry.pl should exit early if there aren't any reports to send
You need to log in before you can comment on or make changes to this bug.