1185956 - Windows 10: border-color and box-shadow of URL bar and search field should be animated

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P4)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Let's add a subtle transition to the border of the URL bar and search field on Windows 10.

Can be done by adding this:
> transition-property: border-color, box-shadow;
> transition-duration: 0.1s;

to this rule:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1223

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8637362 [details] [diff] [review]
Patch

Seems like you should just set the transition in the win10 media query rather than resetting it to none for vista, win7 and win8 && :not(:-moz-lwtheme).

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/421d09ea68e4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/421d09ea68e4

Comment 6

[Nazir Ahmed Sabbir [:NaSb]]

Successfully reproduce in Nightly 42.0a1 (2015-07-21) (Build ID: 20150721030212) on Windows 10 64 Bit.

This Bug is now verified as fixed on Latest Nightly 42.0a1 (2015-08-05) 

Build ID: 20150805030208
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0

Comment 7

[:Gijs (he/him)]

Should we uplift to 41? Maybe not super important on its own, but it'll help make things look polished + ease other uplifts if there aren't subtle differences like this one.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8638102 [details] [diff] [review]
Patch v2

Approval Request Comment
[Feature/regressing bug #]: Theme polish for Windows 10
[User impact if declined]: less polished UI
[Describe test coverage new/current, TreeHerder]: manual testing
[Risks and why]: none, simple CSS fix
[String/UUID change made/needed]: none

This is a very simple low risk CSS change that we should uplift to 41, being closer to the Windows 10 release.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8638102 [details] [diff] [review]
Patch v2

Verified on Nightly. Aurora+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a15b3a7977a3