Closed Bug 1194590 Opened 6 years ago Closed 6 years ago

URL and search bar border and box-shadow transition should only be used for the default theme

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [testday-20150901])

Attachments

(1 file)

patch
1.19 KB, patch
Gijs
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
We're only changing the border color and adding a box-shadow on hover and focus for the default theme.
Attachment #8647902 - Flags: review?(jaws)
OS: Unspecified → Windows 10
Comment on attachment 8647902 [details] [diff] [review]
patch

Review of attachment 8647902 [details] [diff] [review]:
-----------------------------------------------------------------

This probably wants uplift. :-(
Attachment #8647902 - Flags: review?(jaws) → review+
Flags: qe-verify-
I'm not sure I understand the impact here. What's the UX for users on the non-default theme with this?
Flags: needinfo?(dao)
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/28133afb0caf
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
(In reply to Justin Dolske [:Dolske] from comment #3)
> I'm not sure I understand the impact here. What's the UX for users on the
> non-default theme with this?

There's no visible impact.
Flags: needinfo?(dao)
This has been verified fixed in a QA test day.
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20150901]
You need to log in before you can comment on or make changes to this bug.