Closed Bug 1186022 Opened 10 years ago Closed 10 years ago

Firefox download page sends x86 build to my ARMv8 phone

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: blassey, Assigned: kohei)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [kb=1811674] )

Attachments

(2 files)

2015-07-21 14.53.41.png
256.42 KB, image/png
Details
pull request
44 bytes, text/x-github-pull-request
Details | Review
Attached image 2015-07-21 14.53.41.png —
Tested with Beta, this is a Samsung Galaxy S6 Active
What is your user agent? Any chance you were in desktop mode?
tracking-fennec: ? → ---
Component: General → Pages & Content
Product: Firefox for Android → www.mozilla.org
Version: Trunk → Production
Mozilla/5.0 (Android 5.0.2; Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Whiteboard: [kb=1811674]
See Also: → 686489
I cannot test the device myself, but looks like Samsung Galaxy S6 Active is powered by ARMv8, and the download buttons only support ARMv7 and x86 so far. The detection is done by the navigator.platform property: https://github.com/mozilla/bedrock/blob/master/media/js/base/site.js#L104-L108 Is ARMv8 officially supported by Fennec, btw?
Blocks: download-buttons
Flags: needinfo?(blassey.bugs)
yes
Flags: needinfo?(blassey.bugs)
Okay, I'll fix the issue.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Summary: Firefox download page sends x86 build to my ARM phone → Firefox download page sends x86 build to my ARMv8 phone
Attached file pull request —
Brad, can you please check your navigator.platform property value?
Flags: needinfo?(blassey.bugs)
Linux aarch64
Flags: needinfo?(blassey.bugs)
That's why! I'll update my PR shortly.
My PR has been pushed to https://www-demo5.allizom.org/en-US/firefox/channel/#developer Please test. My test using the User Agent Switcher add-on works fine.
Flags: needinfo?(blassey.bugs)
Yup, that works. I presume we won't close this out until it hits production.
Status: ASSIGNED → NEW
Flags: needinfo?(blassey.bugs)
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/156ccf09b832c4efbe6bc29b8efed09d703fd07b Fix Bug 1186022 - Firefox download page sends x86 build to my ARMv8 phone https://github.com/mozilla/bedrock/commit/0997997cc062ac11857ef13b30a14156f89355b5 Merge pull request #3166 from kyoshino/bug-1186022-android-armv8 Fix Bug 1186022 - Firefox download page sends x86 build to my ARMv8 phone
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
:blassey the fix is now in production. Would you mind verifying the download button on http://www.mozilla.org/en-us/firefox/channel/#developer works with your device now?
Flags: needinfo?(blassey.bugs)
Verified
Status: RESOLVED → VERIFIED
Flags: needinfo?(blassey.bugs)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: