Closed Bug 1186219 Opened 5 years ago Closed 5 years ago

Skip the test_value* tests on B2G opt emulator builds

Categories

(Core :: Layout, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

They're already disabled on debug. Try says B2G opt M9 is green with them disabled.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d8d5c90e3ae&exclusion_profile=false
Attached patch PatchSplinter Review
Attachment #8636821 - Flags: review?(dholbert)
If this can wait for a bit, I'd be interested to see if we can fix this "correctly".

In particular -- after a ping from RyanVM earlier today, I've been looking into using JS Promises & executeSoon to allow for periodic garbage collections in a related test, "test_extra_inherit_initial.html", which also has memory blowup on B2G.

If that strategy pans out, I think we can apply it across each of these tests to fix their memory explosion.
Bug 1168222 might be the "right" bug for that.
See Also: → 1186224
(In reply to Daniel Holbert [:dholbert] from comment #2)
> If this can wait for a bit, I'd be interested to see if we can fix this
> "correctly".

Never mind -- as noted in bug 1186224 comment 6, my brief attempt at this didn't pan out like I'd hoped. (It reduced memory usage locally, but B2G debug M25 still timed out in the test I was trying to improve in 7 out of 8 test runs.)
Comment on attachment 8636821 [details] [diff] [review]
Patch

This is unfortunate, but r=me in the interests of getting some (rather than none) test coverage here.
Attachment #8636821 - Flags: review?(dholbert) → review+
(i.e. in the interests of letting us unhide B2G opt M9 test runs, I mean)
https://hg.mozilla.org/mozilla-central/rev/d82e6e3d419e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.