1186219 - Skip the test_value* tests on B2G opt emulator builds

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

They're already disabled on debug. Try says B2G opt M9 is green with them disabled.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d8d5c90e3ae&exclusion_profile=false

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Patch

Comment 2

[Daniel Holbert [:dholbert]]

If this can wait for a bit, I'd be interested to see if we can fix this "correctly".

In particular -- after a ping from RyanVM earlier today, I've been looking into using JS Promises & executeSoon to allow for periodic garbage collections in a related test, "test_extra_inherit_initial.html", which also has memory blowup on B2G.

If that strategy pans out, I think we can apply it across each of these tests to fix their memory explosion.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Bug 1168222 might be the "right" bug for that.

Comment 4

[Daniel Holbert [:dholbert]]

(I think you meant to add Bug 1168222 -- not bug 1186224 [which is already a dependency] -- to "see also" field. Fixing.)

Comment 5

[Daniel Holbert [:dholbert]]

[er, disregard comment 4; I got confused because blocking bug 1168224 & see-also bug 1186224 looked like they were the same bug numbers. Leaving philor's bug as see-also, though.]

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> If this can wait for a bit, I'd be interested to see if we can fix this
> "correctly".

Never mind -- as noted in bug 1186224 comment 6, my brief attempt at this didn't pan out like I'd hoped. (It reduced memory usage locally, but B2G debug M25 still timed out in the test I was trying to improve in 7 out of 8 test runs.)

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 8636821 [details] [diff] [review]
Patch

This is unfortunate, but r=me in the interests of getting some (rather than none) test coverage here.

Comment 8

[Daniel Holbert [:dholbert]]

(i.e. in the interests of letting us unhide B2G opt M9 test runs, I mean)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d82e6e3d419e

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d82e6e3d419e