1186250 - Too much space above tabs on Windows 10

Status: RESOLVED DUPLICATE of bug 1173731

(Firefox :: Theme, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Design spec

Per design spec, our Windows 10 caption buttons (1173725) should extend all the way down to the top of the navbar. (They're a bit taller than the native widgets, but this is intentional to avoid a pointless gap between the button and the navbar).

Currently there's a gap, so we should fix that. That also reduces the overly-large amount of space above the tabs, which also looks a little odd right now.

I suspect a fix for bug 1173732 will be important here, because otherwise it's kind of hard to grab the window to drag it when the excess space is removed.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Current screenshot

This is a screenshot of how a current build looks, as of bug 1173728 removing the border from tabs.

The right is a browser on a 200% scaled display, the left is a 100% scaled display (normal) that I pixel-doubled in Photoshop just to compare the two. I added pink measurements in 100% pixels.

There's a 10 pixel gap under the caption buttons, and 18 pixels of space between the top of the tabs and the top of the window. So to make the two align, we need to nuke 10 pixels of that padding.

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Screenshot with patch

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8636852 [details] [diff] [review]
Patch v.1

(In reply to Justin Dolske [:Dolske] from comment #0)
> I suspect a fix for bug 1173732 will be important here, because otherwise
> it's kind of hard to grab the window to drag it when the excess space is
> removed.

Yes, philipp and I didn't think we could do this without that. This is basically a duplicate of bug 1173731. It's weird though that you arrived at -10px rather than the -2px that philipp and I came up with. This seems excessive in terms of keeping the title bar as a mouse target even when taking bug 1173732 into account.

Comment 5

[Justin Dolske [:Dolske]]

(In reply to Dão Gottwald [:dao] from comment #4)

> It's weird though that you arrived at
> -10px rather than the -2px that philipp and I came up with. This seems
> excessive in terms of keeping the title bar as a mouse target even when
> taking bug 1173732 into account.

I got here by noticing the new caption button is bigger than other Win10 apps, and shorlander pointed out the size is deliberate, as the spec also calls for shrinking the space above the tabs (this bug / 1173731) so that there's no gap between the caption button and the navbar.

So either need to remove 10px as this patch does, or remove none/less and make the caption buttons the normal size for Win10 apps.

I'm leaning towards the latter, at least for FF40. We're into the last betas, and that's not an ideal time to be changing widget code and figuring out usability of a smaller drag/resize target.

NI for shorlander and phlsa to duke it out over the design spec. :)

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I agree that it's late and that there are too many open questions to land this for 40.
I'll defer to Stephen for the size of the caption buttons, but IMO they should fill the height when the window is maximized and otherwise be the same size as e.g. Windows Mails buttons.

That said, I'd love to test this patch - do you happen to have a build with it applied?

Comment 7

[Stephen Horlander [:shorlander]]

(In reply to Philipp Sackl [:phlsa] please use needinfo from comment #6)
> I agree that it's late and that there are too many open questions to land
> this for 40.
> I'll defer to Stephen for the size of the caption buttons, but IMO they
> should fill the height when the window is maximized and otherwise be the
> same size as e.g. Windows Mails buttons.
> 
> That said, I'd love to test this patch - do you happen to have a build with
> it applied?

Yeah, I agree with this. Looks like the height of the native buttons is 31px, but I would be OK making ours 32px so the icons would be properly centered.

Comment 8

[Justin Dolske [:Dolske]]

Ok, let's deal with the caption button size for Firefox 40 in bug 1187631.

We can leave this bug / bug 1173731 open for figuring if/how to reduce the space above the tabs in Firefox 41+.

Comment 9

[Dão Gottwald [:dao]]

Merging this into the original bug filed on this, bug 1173731. If a 2px reduction isn't exactly what we need, we can change that there.