1186253 - Too much space between menubar and tabs on Windows 10

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect, P2)

Description

[Justin Dolske [:Dolske]]

While working on bug 1186250 I noticed that there's also extra space between the menubar and the tabs, even with my fix.

On my system, there's 15.5px (CSS) of padding-bottom on #toolbar-menubar. This can be reduced by 5px (to 10.5px) to make the caption buttons align with the top of the tabs. This is the minimum for the always-on menubar, any more and the two will overlap. For the alt-key triggered menubar, we could reduce this further.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Screenshot (w/ bug 1186250 fix)

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Hacky fix

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Screenshot of hacky fix

Comment 4

[Justin Dolske [:Dolske]]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Created attachment 8636858 [details] [diff] [review]
> Hacky fix

(This obviously needs more work, I just subtracted the magic 5px value because that's what worked for me. Needs someone to dive into how this value is computed, and probably be smarter about how we compute the value.)

Comment 5

[Justin Dolske [:Dolske]]

P2 because we know a lot of users have the menubar enabled, and are thus experiencing this.

Comment 6

[Dão Gottwald [:dao]]

Attachment: unpatched nightly wih menu bar

I don't really see any significant room for reducing the space here. That we could remove 5px as suggested earlier seems a bit too optimistic. We probably don't want the caption buttons to touch the tabs, right?

The only real options I see would be to make the caption buttons smaller or to let tabs not stretch under the caption buttons (like when the menubar is hidden).

Comment 7

[Dão Gottwald [:dao]]

Attachment: straw man patch

(In reply to Dão Gottwald [:dao] from comment #6)
> to let tabs not stretch under the caption buttons (like when the menubar is
> hidden).

That would be this patch.