1186260 - Favicon in site info doorhanger is too large when using default favicon

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

It's a bit smaller with regular favicons.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The page I used was: https://www.amazon.com/gp/help/customer/display.html?nodeId=200226050 (which only seems to have trouble accessing the favicon on the mobile site).

Comment 2

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1186260 - Favicon in site info doorhanger is too large when using default favicon. r=ally

Bug 1186260 - Favicon in site info doorhanger is too large when using default favicon. r=ally

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Add bounding to favicon compound drawable

Comment 4

[Chenxia Liu [:liuche]]

Ally, I'm reusing an approach I used as part of the Mixed Content icons bug 1177576, so this code should look familiar.

Comment 5

[Chenxia Liu [:liuche]]

This is a regression from bug 1173887, which landed in 41.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8637483 [details]
MozReview Request: Bug 1186260 - Favicon in site info doorhanger is too large when using default favicon. r=ally

https://reviewboard.mozilla.org/r/13895/#review12929

Ship It!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/922aaca0f5f8

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/922aaca0f5f8

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-08-17-12-10-37.png

Verified as fixed using:
Device: LG Nexus 4 (Android 5.0)
Build: Firefox for Android 43.0a1 (2015-08-17)