Closed Bug 1186420 Opened 6 years ago Closed 6 years ago

Autophone - update requirements and deploy thclient 1.6

Categories

(Testing :: Autophone, defect)

defect
Not set
normal

Tracking

(firefox42 affected)

RESOLVED FIXED
Tracking Status
firefox42 --- affected

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch bug-1186420-v1.patch (obsolete) — Splinter Review
Attachment #8637228 - Flags: review?(gbrown)
Comment on attachment 8637228 [details] [diff] [review]
bug-1186420-v1.patch

thclient 1.6 is not backwards compatible.
Attachment #8637228 - Flags: review?(gbrown)
Attachment #8637228 - Attachment is obsolete: true
Depends on: 1177257
Comment on attachment 8637933 [details] [diff] [review]
bug-1186420-v2.patch

gbrown is away longer than I thought. Mark, can you take a look?
Attachment #8637933 - Flags: review?(gbrown) → review?(mcote)
Comment on attachment 8637933 [details] [diff] [review]
bug-1186420-v2.patch

Review of attachment 8637933 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.  In the future, perhaps you can rope jmaher in for reviews, since he's been doing Autophone stuff recently. :)

::: autophonetreeherder.py
@@ +383,5 @@
> +                # Job Info panel, it is important to only specify one log
> +                # file to prevent the multiple log buttons from hiding the
> +                # retrigger button. If the test is a Unit Test, its log
> +                # will marked as the log file. Otherwise, the Autophone
> +                # log will be marked as the log file.

Heh kind of gross that we have to hack around UI problems by limiting what we send.  Can you ensure there's a Treeherder bug on file and mention it here, so that some day we could send them all?  This assumes it's useful to specify multiple log files; if not, please modify the comment appropriately.
Attachment #8637933 - Flags: review?(mcote) → review+
I'm still breaking him in. You haven't gotten rid of me and Autophone quite yet. ;-)

https://github.com/mozilla/autophone/commit/91eac8f41de0284560509fabd3297828531a70c9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1187183
You need to log in before you can comment on or make changes to this bug.