Last Comment Bug 1186420 - Autophone - update requirements and deploy thclient 1.6
: Autophone - update requirements and deploy thclient 1.6
Status: RESOLVED FIXED
:
Product: Testing
Classification: Components
Component: Autophone (show other bugs)
: Trunk
: Unspecified Unspecified
-- normal (vote)
: ---
Assigned To: Bob Clary [:bc:]
:
:
Mentors:
Depends on: 1177257 1186366
Blocks: 1186357 1187183
  Show dependency treegraph
 
Reported: 2015-07-22 07:31 PDT by Bob Clary [:bc:]
Modified: 2015-07-23 20:24 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
affected


Attachments
bug-1186420-v1.patch (505 bytes, patch)
2015-07-22 07:48 PDT, Bob Clary [:bc:]
no flags Details | Diff | Splinter Review
bug-1186420-v2.patch (11.12 KB, patch)
2015-07-23 08:01 PDT, Bob Clary [:bc:]
mcote: review+
Details | Diff | Splinter Review

Description User image Bob Clary [:bc:] 2015-07-22 07:31:52 PDT

    
Comment 1 User image Bob Clary [:bc:] 2015-07-22 07:48:34 PDT
Created attachment 8637228 [details] [diff] [review]
bug-1186420-v1.patch
Comment 2 User image Bob Clary [:bc:] 2015-07-22 08:17:16 PDT
Comment on attachment 8637228 [details] [diff] [review]
bug-1186420-v1.patch

thclient 1.6 is not backwards compatible.
Comment 4 User image Bob Clary [:bc:] 2015-07-23 08:03:50 PDT
Comment on attachment 8637933 [details] [diff] [review]
bug-1186420-v2.patch

gbrown is away longer than I thought. Mark, can you take a look?
Comment 5 User image Mark Côté [:mcote] 2015-07-23 19:35:32 PDT
Comment on attachment 8637933 [details] [diff] [review]
bug-1186420-v2.patch

Review of attachment 8637933 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.  In the future, perhaps you can rope jmaher in for reviews, since he's been doing Autophone stuff recently. :)

::: autophonetreeherder.py
@@ +383,5 @@
> +                # Job Info panel, it is important to only specify one log
> +                # file to prevent the multiple log buttons from hiding the
> +                # retrigger button. If the test is a Unit Test, its log
> +                # will marked as the log file. Otherwise, the Autophone
> +                # log will be marked as the log file.

Heh kind of gross that we have to hack around UI problems by limiting what we send.  Can you ensure there's a Treeherder bug on file and mention it here, so that some day we could send them all?  This assumes it's useful to specify multiple log files; if not, please modify the comment appropriately.
Comment 6 User image Bob Clary [:bc:] 2015-07-23 20:21:23 PDT
I'm still breaking him in. You haven't gotten rid of me and Autophone quite yet. ;-)

https://github.com/mozilla/autophone/commit/91eac8f41de0284560509fabd3297828531a70c9

Note You need to log in before you can comment on or make changes to this bug.