1186467 - Convert NativeJSContainer to use new JNI scheme

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

NativeJSContainer currently use mozglue stubs, but we should convert it to use the new JNI scheme that automatically forward native calls to corresponding instances.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add some JNI utilities for convenience (v1)

This patch adds:
* Conversion operator from String::Param to String::LocalRef.
* More overloads of the jni::ThrowException function.
* name members to built-in types like jni::Object, jni::String, etc.
  This allows using jni::Accessors::EnsureClassRef on built-in types
  to get built-in class refs (e.g. jclass for java/lang/String).
* Ability to implicitly convert LocalRef<Cls> to LocalRef<Object>
* Fixes for bugs in LocalRef/GlobalRef where new refs are not created.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Make NativeJSContainer and NativeJSObject extend JNIObject (v1)

JNIObject is the base class for any class that wish to use per-instance
native methods. It encapsulates the long native pointer that used to be
in NativeJSContainer.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update generated JNI bindings (v1)

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Rewrite NativeJSContainer to use new native JNI scheme (v1)

This patch makes NativeJSContainer use per-instance native methods.
NativeJSContainer is also updated to use smart JNI reference classes.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8641160 [details] [diff] [review]
Rewrite NativeJSContainer to use new native JNI scheme (v1)

Review of attachment 8641160 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cbc7f63aba7
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e9a116e559
https://hg.mozilla.org/integration/mozilla-inbound/rev/68f6ca13d044
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9b044bd018a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7cbc7f63aba7
https://hg.mozilla.org/mozilla-central/rev/c5e9a116e559
https://hg.mozilla.org/mozilla-central/rev/68f6ca13d044
https://hg.mozilla.org/mozilla-central/rev/a9b044bd018a