1186700 - Inserting data into the mail_staging table fails on PostgreSQL due to unspecified BLOB type

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Matt Tyson]

Attachment: mailer_blob_fix

The "INSERT INTO mail_staging" in Bugzilla/Mailer.pm fails on Postgres as we don't tell the driver that the column is a BLOB type, which means that it doesn't know to escape the data properly for a blob type.

Attached is a patch to tell the driver that we are passing in a BLOB.

Comment 1

[Matt Tyson]

Attachment: mailer_blob_fix_2

Previous patch had an unneeded "my $dbh = Bugzilla->dbh".  (A leftover from porting the patch from 4.4)

Comment 2

[Frédéric Buclin]

Comment on attachment 8637577 [details] [diff] [review]
mailer_blob_fix_2

>+        my $sth = $dbh->prepare("INSERT INTO mail_staging (message) VALUES(?)");

Nit: add a whitespace after VALUES: VALUES (?). Otherwise this looks good.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 8637577 [details] [diff] [review]
mailer_blob_fix_2

Review of attachment 8637577 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv with LpSolit's change.

Gerv

Comment 4

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   61a971c..12ca183  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   7fec569..fdc4581  5.0 -> 5.0