Closed Bug 1186811 Opened 10 years ago Closed 10 years ago

Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(4 files)

(part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
4.46 KB, patch
baku
: review+
Details | Diff | Splinter Review
(part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
2.60 KB, patch
baku
: review+
Details | Diff | Splinter Review
(part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
2.06 KB, patch
baku
: review+
Details | Diff | Splinter Review
(part 4) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
1.55 KB, patch
baku
: review+
Details | Diff | Splinter Review
Because iterators are so much nicer than enumerate functions. There are six occurrences of EnumerateRead() in this directory. A note to the assignee: to preserve existing behaviour, you should probably use nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Attachment #8688773 - Flags: review?(amarchesini)
Attachment #8688774 - Flags: review?(amarchesini)
Attachment #8688775 - Flags: review?(amarchesini)
Attachment #8688776 - Flags: review?(amarchesini)
Attachment #8688773 - Flags: review?(amarchesini) → review+
Attachment #8688774 - Flags: review?(amarchesini) → review+
Attachment #8688775 - Flags: review?(amarchesini) → review+
Attachment #8688776 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e2ddbd47627da9d7ac76362fc1b072a3459a693 Bug 1186811 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku. https://hg.mozilla.org/integration/mozilla-inbound/rev/89352365bed03249cef56c3c87afb4bf43daf813 Bug 1186811 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku. https://hg.mozilla.org/integration/mozilla-inbound/rev/0c6c2f077d829bec4921ed4c47df055dd8608470 Bug 1186811 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku. https://hg.mozilla.org/integration/mozilla-inbound/rev/78ffe07a4a498c8284751e4bc04469c2a8daa648 Bug 1186811 (part 4) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: