Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
Because iterators are so much nicer than enumerate functions.

There are six occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
(Assignee)

Comment 1

3 years ago
Created attachment 8688773 [details] [diff] [review]
(part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
(Assignee)

Updated

3 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8688774 [details] [diff] [review]
(part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
(Assignee)

Comment 3

3 years ago
Created attachment 8688775 [details] [diff] [review]
(part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
(Assignee)

Comment 4

3 years ago
Created attachment 8688776 [details] [diff] [review]
(part 4) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators
(Assignee)

Updated

3 years ago
Attachment #8688773 - Flags: review?(amarchesini)
(Assignee)

Updated

3 years ago
Attachment #8688774 - Flags: review?(amarchesini)
(Assignee)

Updated

3 years ago
Attachment #8688775 - Flags: review?(amarchesini)
(Assignee)

Updated

3 years ago
Attachment #8688776 - Flags: review?(amarchesini)
Attachment #8688773 - Flags: review?(amarchesini) → review+
Attachment #8688774 - Flags: review?(amarchesini) → review+
Attachment #8688775 - Flags: review?(amarchesini) → review+
Attachment #8688776 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e2ddbd47627da9d7ac76362fc1b072a3459a693
Bug 1186811 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku.

https://hg.mozilla.org/integration/mozilla-inbound/rev/89352365bed03249cef56c3c87afb4bf43daf813
Bug 1186811 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c6c2f077d829bec4921ed4c47df055dd8608470
Bug 1186811 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku.

https://hg.mozilla.org/integration/mozilla-inbound/rev/78ffe07a4a498c8284751e4bc04469c2a8daa648
Bug 1186811 (part 4) - Replace nsBaseHashtable::EnumerateRead() calls in dom/storage/ with iterators. r=baku.

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e2ddbd47627
https://hg.mozilla.org/mozilla-central/rev/89352365bed0
https://hg.mozilla.org/mozilla-central/rev/0c6c2f077d82
https://hg.mozilla.org/mozilla-central/rev/78ffe07a4a49
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.