1186817 - Replace nsBaseHashtable::EnumerateRead() calls in security/ with iterators

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are two occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: Bug 1186817 - Replace nsBaseHashtable::EnumerateRead() calls in security/ with iterators.

Bug 1186817 - Replace nsBaseHashtable::EnumerateRead() calls in security/ with iterators.

Comment 2

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a75a89c355c9

Comment 3

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8681297 [details]
MozReview Request: Bug 1186817 - Replace nsBaseHashtable::EnumerateRead() calls in security/ with iterators.

https://reviewboard.mozilla.org/r/23797/#review21305

Great! Thanks for doing this.

Comment 4

[:Cykesiopka]

Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ef26daa0fcc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ef26daa0fcc

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8ef26daa0fcc

Comment 8

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion