Add profiling support to talos TPS

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8638714 [details] [diff] [review]
patch
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Here's my WIP. Any idea on the proper way to include Profiler.js? chrome://pageloader/content/Profiler.js works from xul but I'm not familiar with scriptloader.
Flags: needinfo?(jmaher)
would it be possible to have profiler.js as a file in talos-powers and we could cu.import(chrome:/talos-powers/content/profiler.js).  Then all instances could use this.

Ideally that would work, but maybe some issues with chrome vs content might creep up.
Flags: needinfo?(jmaher)
(Assignee)

Comment 4

2 years ago
Created attachment 8639488 [details] [diff] [review]
patch
Attachment #8638714 - Attachment is obsolete: true
Attachment #8639488 - Flags: review?(blassey.bugs)
(Assignee)

Comment 5

2 years ago
This depends on bug 1187451 but just because the hunks got merged and to minimize bitrot.
Depends on: 1187451
(Assignee)

Comment 6

2 years ago
Created attachment 8639517 [details] [diff] [review]
patch v2
Attachment #8639488 - Attachment is obsolete: true
Attachment #8639488 - Flags: review?(blassey.bugs)
Attachment #8639517 - Flags: review?(blassey.bugs)
Attachment #8639517 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 7

2 years ago
url:        https://hg.mozilla.org/build/talos/rev/574da36e8723a0546152e4e5d4623250702accd7
changeset:  574da36e8723a0546152e4e5d4623250702accd7
user:       Benoit Girard <b56girard@gmail.com>
date:       Mon Jul 27 16:43:42 2015 -0400
description:
Bug 1187442 - Add profiling support to talos TPS. r=blassey
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
backed out talos change:
http://hg.mozilla.org/build/talos/rev/24ecc5140689

this is because tps didn't run on try and timed out- it appears to be this change:
http://hg.mozilla.org/build/talos/rev/da09edf6d984

but backing it out has a lot of merge conflicts so we backed all of them out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

2 years ago
url:        https://hg.mozilla.org/build/talos/rev/582072d221f53c5deb02798d2fa57080e38d3a3a
changeset:  582072d221f53c5deb02798d2fa57080e38d3a3a
user:       Benoit Girard <b56girard@gmail.com>
date:       Mon Jul 27 16:43:42 2015 -0400
description:
Bug 1187442 - Add profiling support to talos TPS. r=blassey
Depends on: 1192367
some of this has landed in tree, are we done here?
(Assignee)

Comment 11

2 years ago
The patch is tangled with bug 1187451. We could split it up but ATM I just plan on waiting for bug 1187451 to land. Unless I change my mind :).
(Assignee)

Comment 12

2 years ago
Alright this is all landed now!
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.