Closed Bug 1187442 Opened 9 years ago Closed 9 years ago

Add profiling support to talos TPS

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 2 obsolete files)

patch v2
2.80 KB, patch
blassey
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Here's my WIP. Any idea on the proper way to include Profiler.js? chrome://pageloader/content/Profiler.js works from xul but I'm not familiar with scriptloader.
Flags: needinfo?(jmaher)
would it be possible to have profiler.js as a file in talos-powers and we could cu.import(chrome:/talos-powers/content/profiler.js). Then all instances could use this. Ideally that would work, but maybe some issues with chrome vs content might creep up.
Flags: needinfo?(jmaher)
Attached patch patch (obsolete) — — Splinter Review
Attachment #8638714 - Attachment is obsolete: true
Attachment #8639488 - Flags: review?(blassey.bugs)
This depends on bug 1187451 but just because the hunks got merged and to minimize bitrot.
Depends on: 1187451
Attached patch patch v2 — — Splinter Review
Attachment #8639488 - Attachment is obsolete: true
Attachment #8639488 - Flags: review?(blassey.bugs)
Attachment #8639517 - Flags: review?(blassey.bugs)
Attachment #8639517 - Flags: review?(blassey.bugs) → review+
url: https://hg.mozilla.org/build/talos/rev/574da36e8723a0546152e4e5d4623250702accd7 changeset: 574da36e8723a0546152e4e5d4623250702accd7 user: Benoit Girard <b56girard@gmail.com> date: Mon Jul 27 16:43:42 2015 -0400 description: Bug 1187442 - Add profiling support to talos TPS. r=blassey
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
backed out talos change: http://hg.mozilla.org/build/talos/rev/24ecc5140689 this is because tps didn't run on try and timed out- it appears to be this change: http://hg.mozilla.org/build/talos/rev/da09edf6d984 but backing it out has a lot of merge conflicts so we backed all of them out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
url: https://hg.mozilla.org/build/talos/rev/582072d221f53c5deb02798d2fa57080e38d3a3a changeset: 582072d221f53c5deb02798d2fa57080e38d3a3a user: Benoit Girard <b56girard@gmail.com> date: Mon Jul 27 16:43:42 2015 -0400 description: Bug 1187442 - Add profiling support to talos TPS. r=blassey
some of this has landed in tree, are we done here?
The patch is tangled with bug 1187451. We could split it up but ATM I just plan on waiting for bug 1187451 to land. Unless I change my mind :).
Alright this is all landed now!
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: