Closed Bug 1188129 Opened 9 years ago Closed 9 years ago

Use a universal constructor to create and init PersistentRooted

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

This is the same treatment we gave to Rooted last week. It worked well there, so let's do it here too.
Attachment #8639539 - Flags: review?(jcoppeard)
Blocks: 1188197
Comment on attachment 8639539 [details] [diff] [review]
use_a_universal_constructor_for_persistentrooted-v0.diff

Review of attachment 8639539 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/public/RootingAPI.h
@@ +1062,1 @@
>          ptr = initial;

I think we need Forward<> here too.
Attachment #8639539 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/79d18ff4fe28
Assignee: nobody → terrence
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.