Use a universal constructor to create and init PersistentRooted

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8639539 [details] [diff] [review]
use_a_universal_constructor_for_persistentrooted-v0.diff

This is the same treatment we gave to Rooted last week. It worked well there, so let's do it here too.
Attachment #8639539 - Flags: review?(jcoppeard)
(Assignee)

Updated

3 years ago
Blocks: 1188197
Comment on attachment 8639539 [details] [diff] [review]
use_a_universal_constructor_for_persistentrooted-v0.diff

Review of attachment 8639539 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/public/RootingAPI.h
@@ +1062,1 @@
>          ptr = initial;

I think we need Forward<> here too.
Attachment #8639539 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/79d18ff4fe28
Assignee: nobody → terrence
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.