1188138 - Default buttons have their borders and frames drawn twice on GTK3

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

If a button is a default button and has a relief, its background and frame will be drawn twice (see moz_gtk_button_paint in gtk3drawing.c, note that case where state->isDefault and relief == GTK_RELIEF_NORMAL). This appears to be unintended, and is not done by upstream GTK's gtk_button_draw.

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Prevent default buttons from being drawn twice on GTK3.

This should more accurately follow the upstream GTK implementation, and make default buttons look correct. Thanks!

Comment 2

[Andrew Comminos [:acomminos]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b90664b97f9

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/570c40c6fe4b

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/570c40c6fe4b