1188176 - Find bar close icon is nearly invisible in the dark DevEdition theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Brian Grinstead [:bgrins]]

I'm guessing this may end up being a similar fix to Bug 1185889, but when I open the find bar in the dark Dev Edition theme, the close icon is barely visible.  I'd expect it to match the close icon shown on the tabs

Comment 1

[arni2033]

Attachment: 1188176 – [Windows 7] Close icon for the find bar is nearly invisible in the dark DevEdition Theme.png

Just by-the-way: the same is happening on Win7 actually. That issue isn't listed on Bugzilla.

Comment 2

[Dão Gottwald [:dao]]

Cutting the scope back to the find bar again, since the situation is a bit more complicated for the close icon in other contexts...

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8654215 [details] [diff] [review]
patch

Review of attachment 8654215 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! For OSX support, can you please add:

`:root[devtoolstheme="dark"] .findbar-closebutton:not(:hover),`

to this selector as well (and the 2x version): https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/devedition.css?offset=1300#106

::: browser/themes/windows/devedition.css
@@ +109,5 @@
>    /* Add margin otherwise it looks weird */
>    -moz-margin-start: 2px;
>  }
>  
> +:root[devtoolstheme="dark"] .findbar-closebutton,

Does this handle the red hover state, or should it be :not(:hover)?

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: osx-closebutton.patch

Addresses the first part of my review comment (OSX support)

Comment 6

[Dão Gottwald [:dao]]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> ::: browser/themes/windows/devedition.css
> @@ +109,5 @@
> >    /* Add margin otherwise it looks weird */
> >    -moz-margin-start: 2px;
> >  }
> >  
> > +:root[devtoolstheme="dark"] .findbar-closebutton,
> 
> Does this handle the red hover state

Yes, it does

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/de2ff26d1759
https://hg.mozilla.org/integration/fx-team/rev/29f4cc82e74e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de2ff26d1759
https://hg.mozilla.org/mozilla-central/rev/29f4cc82e74e

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Reproduced on latest 42.0a2 Aurora, build ID: 20150916004013.
Confirming the fix on latest Nightly, build ID: 20150916030203. Tested on Windows 10 64-bit and Windows 7 64-bit.