1188619 - search keywords not removed when search engine is removed

Status: RESOLVED DUPLICATE of bug 341833

(Firefox :: Search, defect, P3)

Description

[Rick Alther]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150728004007

Steps to reproduce:

* Open Search Prefs
* add a keyword to a search engine - e.g. 'aa'
* Remove that search engine
* Try to assign that keyword to another search engine.  It won't take.  The keyword simply disappears.  This is because Firefox thinks the keyword is still assigned to the now removed search engine.


Actual results:

The keyword assigned to the removed search engine is still 'assigned' to the now non-existant search engine.  In fact, if you add that search engine back, the keyword comes back with it.


Expected results:

When the search engine is removed, the keyword assigned to it (if any) should also be removed.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I could only partially reproduce this on the current Nightly.
Tried adding dict.cc as an engine, assigning it the 'd' keyword, then removing the engine and assigning 'd' to Wikipedia, which worked fine. However, when I re-added dict.cc the keyword was present on both engines (but using it pointed me to Wikipedia).

I agree though that we should just remove the keywords along with the search engine.

Comment 2

[Springtime]

I'm wondering if this is related to a bug I experienced today that is preventing me from using 'e' as a keyword on a bookmark I've been using for years.

The bookmark was accidentally deleted earlier today, and then restored back by overwriting the places.sqlite file in the profile with an earlier version from a backup. However I believe the issue was experienced right before I accidentally deleted the bookmark as I was trying to discover why the search wasn't working by examining the bookmark.

Nevertheless while not necessarily the same Search engine pref bug above I wouldn't be surprised if Firefox thinks something hidden is using it and therefor preventing the keyword from being used.

I'd file a separate bug report but I'm not certaint the root cause of the issue.

Comment 3

[Rick Alther]

(In reply to Springtime from comment #2)
> I'd file a separate bug report but I'm not certaint the root cause of the
> issue.
I'd be willing to bet it's the same bug.  They're both treated as 'keywords' and one just invokes a bookmark and the other a search.  In both cases, the bookmark/search engine is deleted, but the associated keyword is not.