If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement View Source

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::System::System UI
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nicoleyee, Assigned: drs)

Tracking

unspecified
FxOS-S6 (04Sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(feature-b2g:2.5+, b2g-master fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Target Milestone: --- → FxOS-S5 (21Aug)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
feature-b2g: --- → 2.5+
(Assignee)

Updated

2 years ago
Target Milestone: FxOS-S5 (21Aug) → FxOS-S6 (04Sep)
(Assignee)

Updated

2 years ago
feature-b2g: 2.5+ → ---
Component: Gaia → Gaia::System::System UI
Whiteboard: planned finished: 3 days

Comment 1

2 years ago
Created attachment 8653198 [details] [review]
[gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Created attachment 8653199 [details] [diff] [review]
Implement "View Source" feature.
(Assignee)

Updated

2 years ago
Attachment #8653198 - Flags: review?(etienne)
Comment on attachment 8653198 [details] [review]
[gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master

Comments on github, I'll take another quick look with those addressed.
Flagging Yura for the settings part in the meantime.

How are we going to trigger the feature? Do we have a separate bug for that?
Attachment #8653198 - Flags: review?(etienne) → review?(yzenevich)
Comment on attachment 8653198 [details] [review]
[gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master

Settings part looks good to me.
Attachment #8653198 - Flags: review?(yzenevich) → review+
feature-b2g: --- → 2.5+
(Assignee)

Comment 5

2 years ago
Created attachment 8655900 [details] [diff] [review]
Implement "View Source" feature.
Attachment #8653199 - Attachment is obsolete: true
(Assignee)

Comment 6

2 years ago
Comment on attachment 8653198 [details] [review]
[gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master

(In reply to Etienne Segonzac (:etienne) from comment #3)
> Comments on github, I'll take another quick look with those addressed.

Thanks, this should fix those, but it also addresses a few changes requested in UI/UX review.

> Flagging Yura for the settings part in the meantime.
> 
> How are we going to trigger the feature? Do we have a separate bug for that?

Sorry this wasn't clear. The meta-bug for this feature is bug 1188667. Yura has already reviewed the Settings changes in bug 1188670. The patch for triggering the feature is in bug 1188673. We separated this out because we anticipated much more discussion about how to trigger it than there ended up being.
Attachment #8653198 - Flags: review+ → review?(etienne)
Comment on attachment 8653198 [details] [review]
[gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master

> Sorry this wasn't clear. The meta-bug for this feature is bug 1188667. Yura
> has already reviewed the Settings changes in bug 1188670. The patch for
> triggering the feature is in bug 1188673. We separated this out because we
> anticipated much more discussion about how to trigger it than there ended up
> being.

Yeah this probably was the right approach :)

Anyway, there's a few (new) comments to address but after that we're good, this is cool!
Attachment #8653198 - Flags: review?(etienne) → review+
(Assignee)

Comment 8

2 years ago
Created attachment 8656707 [details] [diff] [review]
Implement "View Source" feature.

Fixed review comments, carrying r+.
Attachment #8655900 - Attachment is obsolete: true
(Assignee)

Comment 9

2 years ago
https://github.com/mozilla-b2g/gaia/commit/6509cedcb091b99a1035701eb3762e5e8d95e388
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-b2g-master: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.