Closed Bug 1188671 Opened 9 years ago Closed 9 years ago

Implement View Source

Categories

(Firefox OS Graveyard :: Gaia::System::System UI, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::System UI
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.5+, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S6 (04Sep)
Project Flags:
feature-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: nyee, Assigned: drs)

References

Details

Attachments

(2 files, 2 obsolete files)

[gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master
46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review
Implement "View Source" feature.
17.60 KB, patch
Details | Diff | Splinter Review
No description provided.
Target Milestone: --- → FxOS-S5 (21Aug)
Status: NEW → ASSIGNED
feature-b2g: --- → 2.5+
Target Milestone: FxOS-S5 (21Aug) → FxOS-S6 (04Sep)
feature-b2g: 2.5+ → ---
Component: Gaia → Gaia::System::System UI
Whiteboard: planned finished: 3 days
Attached patch Implement "View Source" feature. (obsolete) — — Splinter Review
Attachment #8653198 - Flags: review?(etienne)
Comment on attachment 8653198 [details] [review] [gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master Comments on github, I'll take another quick look with those addressed. Flagging Yura for the settings part in the meantime. How are we going to trigger the feature? Do we have a separate bug for that?
Attachment #8653198 - Flags: review?(etienne) → review?(yzenevich)
Comment on attachment 8653198 [details] [review] [gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master Settings part looks good to me.
Attachment #8653198 - Flags: review?(yzenevich) → review+
feature-b2g: --- → 2.5+
Attached patch Implement "View Source" feature. (obsolete) — — Splinter Review
Attachment #8653199 - Attachment is obsolete: true
Comment on attachment 8653198 [details] [review] [gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master (In reply to Etienne Segonzac (:etienne) from comment #3) > Comments on github, I'll take another quick look with those addressed. Thanks, this should fix those, but it also addresses a few changes requested in UI/UX review. > Flagging Yura for the settings part in the meantime. > > How are we going to trigger the feature? Do we have a separate bug for that? Sorry this wasn't clear. The meta-bug for this feature is bug 1188667. Yura has already reviewed the Settings changes in bug 1188670. The patch for triggering the feature is in bug 1188673. We separated this out because we anticipated much more discussion about how to trigger it than there ended up being.
Attachment #8653198 - Flags: review+ → review?(etienne)
Comment on attachment 8653198 [details] [review] [gaia] DouglasSherk:1188671-view-source > mozilla-b2g:master > Sorry this wasn't clear. The meta-bug for this feature is bug 1188667. Yura > has already reviewed the Settings changes in bug 1188670. The patch for > triggering the feature is in bug 1188673. We separated this out because we > anticipated much more discussion about how to trigger it than there ended up > being. Yeah this probably was the right approach :) Anyway, there's a few (new) comments to address but after that we're good, this is cool!
Attachment #8653198 - Flags: review?(etienne) → review+
Fixed review comments, carrying r+.
Attachment #8655900 - Attachment is obsolete: true
https://github.com/mozilla-b2g/gaia/commit/6509cedcb091b99a1035701eb3762e5e8d95e388
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: