1188752 - PDF.js Print dialog's "Open PDF in Preview" or "Save as PDF" opens an empty PDF file

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Chris Peterson [:cpeterson]]

@ Bas, I bisected this regression to this pushlog, which implicates bug 1167235 ("Use a fast method of double buffering for canvas"):

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d1d45ce7cbf5&tochange=eccde665c72a

STR:
1. Load http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4280.pdf in pdf.js
2. Click pdf.js' "Print" button.
3. From the OS X Print dialog, select the "PDF" drop down menu > "Open PDF in Preview" or "Save as PDF" menu item.

RESULT:
The PDF that is saved or opened in Preview has the correct number of pages, but it is empty.

[Tracking Requested - why for this release]:

This is a regression in Firefox 41.

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked, seems like a bad regression.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I can reproduce this.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

To be clear, this is non-E10S scenario.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Bas is on this, there are some problems on Windows as well.

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Ensure persistance of the surface coming from InitializeWithSurface.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Bas Schouten (:bas.schouten) from comment #5)
> Created attachment 8643512 [details] [diff] [review]
> Ensure persistance of the surface coming from InitializeWithSurface.

Makes the problem go away for me.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8643512 [details] [diff] [review]
Ensure persistance of the surface coming from InitializeWithSurface.

Review of attachment 8643512 [details] [diff] [review]:
-----------------------------------------------------------------

Are the lifetimes OK here, in the sense that we can't do something to the mTarget that would mess things up while we're still in the middle of printing?

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3c11f8a33aa

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7aa35707f31

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3c11f8a33aa
https://hg.mozilla.org/mozilla-central/rev/a7aa35707f31

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Chris, could you please verify that this issue if fixed? That will help me decide whether the patch is ready to be uplifted to Beta41 or not. Thanks!

Comment 12

[Chris Peterson [:cpeterson]]

Verified fixed in Nightly 43 and Aurora 42.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Thanks Chris for the verification!

Bas, this bug is marked as FF41+ tracking. Do you want to request uplift to Beta? Thanks!

Comment 14

[Bas Schouten (:bas.schouten)]

Comment on attachment 8643512 [details] [diff] [review]
Ensure persistance of the surface coming from InitializeWithSurface.

Approval Request Comment
[Feature/regressing bug #]: Bug 1167235
[User impact if declined]: Incorrect printing of canvases
[Describe test coverage new/current, TreeHerder]: Nightly and Aurora usage
[Risks and why]: Low, minor change which returns behavior somewhat closer to pre-bug behavior.
[String/UUID change made/needed]: None

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8643512 [details] [diff] [review]
Ensure persistance of the surface coming from InitializeWithSurface.

Fix was verified and baked for 2 weeks on Nightly. Seems safe to uplift to Beta.

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a2b2c73fe26
https://hg.mozilla.org/releases/mozilla-beta/rev/6662dc966680

Comment 18

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Also verified on Mac OS X 10.8.5 with Firefox 41 Beta 5.