Closed
Bug 1188763
Opened 10 years ago
Closed 10 years ago
replace bcontroller.yml file in xtalos with bcontroller.json
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: parkouss, Assigned: parkouss)
References
Details
Attachments
(1 file, 2 obsolete files)
|
12.84 KB,
patch
|
parkouss
:
review+
|
Details | Diff | Splinter Review |
We don't need to use a yaml format for bcontroller. We could use the json format because it is in standard python lib.
|
Assignee | |
Comment 1•10 years ago
|
||
I did this on top of the work from bug 1187684 - so the patch may need it before being merged.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8640342 [details] [diff] [review]
1188763.patch
Review of attachment 8640342 [details] [diff] [review]:
-----------------------------------------------------------------
great r+ on the first shot!
Attachment #8640342 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
updating the patch with unit tests fixes.
Attachment #8640342 -
Attachment is obsolete: true
Attachment #8640445 -
Flags: review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
I highly suspect this as being the cause for X failures in https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b745227506b.
Fixed here (bug was in xtalos.py, I thought I was smart to use the dict update method).
We should try again with this new patch - probably talos xperf is sufficient.
Attachment #8640445 -
Attachment is obsolete: true
Attachment #8640451 -
Flags: review+
|
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•