Instantbird build bustages from Bug 1138063 and Bug 1186782

RESOLVED FIXED in Instantbird 42

Status

--
blocker
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

trunk
Instantbird 42
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8640588 [details] [diff] [review]
Fix

Two separate bustages.

rs=aleth

Comment 1

3 years ago
Comment on attachment 8640588 [details] [diff] [review]
Fix

Review of attachment 8640588 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/Makefile.in
@@ +5,5 @@
>  
> +FILES := \
> +	install.rdf.in \
> +	$(NULL)
> +FILES_PATH = $(FINAL_TARGET)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}

The key change here is s/:=/=. Everything else shouldn't matter.
(Assignee)

Updated

3 years ago
Assignee: nobody → clokep
Blocks: 1138063, 1186782
Severity: normal → blocker
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8640620 [details] [diff] [review]
Fix v2
Attachment #8640588 - Attachment is obsolete: true
Attachment #8640620 - Flags: review?(aleth)

Comment 3

3 years ago
Comment on attachment 8640620 [details] [diff] [review]
Fix v2

Review of attachment 8640620 [details] [diff] [review]:
-----------------------------------------------------------------

(For future reference, = is expanded when the variable is used, := when it's declared.)
Attachment #8640620 - Flags: review?(aleth) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/comm-central/rev/71156eb5be91
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 42

Comment 5

3 years ago
Sorry, forgot how filter in an if worked :(
(Assignee)

Comment 6

3 years ago
(In reply to Ian Neal from comment #5)
> Sorry, forgot how filter in an if worked :(

Not a problem! Thanks for fixing that in the first place. :)
You need to log in before you can comment on or make changes to this bug.