1186782 - nsMailComps.o: In function `DirectoryProvider': mail/components/build/../shell/DirectoryProvider.h:35: undefined reference to `vtable for mozilla::mail::DirectoryProvider'

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

On  bld-linux64-spot-201 for TB Linux x86-64 comm-central build,

Getting:

./../mail/components/build/nsMailComps.o: In function `DirectoryProvider':
/builds/slave/tb-c-cen-l64-00000000000000000/build/mail/components/build/../shell/DirectoryProvider.h:35: undefined reference to `vtable for mozilla::mail::DirectoryProvider'
/usr/bin/ld: ../../mail/components/build/nsMailComps.o: relocation R_X86_64_PC32 against undefined hidden symbol `_ZTVN7mozilla4mail17DirectoryProviderE' can not be used when making a shared object
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
make[5]: *** [libxul.so] Error 1
make[5]: Leaving directory `/builds/slave/tb-c-cen-l64-00000000000000000/build/objdir-tb/toolkit/library'
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21286
repository: comm-central
start_time: 2015-07-22T22:27:25
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-021
buildname: TB Linux comm-central build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21288
repository: comm-central
start_time: 2015-07-22T22:27:27
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-201
buildname: TB Linux x86-64 comm-central build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21293
repository: comm-central
start_time: 2015-07-22T22:27:26
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-005
buildname: TB Linux x86-64 comm-central leak test build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21291
repository: comm-central
start_time: 2015-07-22T22:27:25
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-146
buildname: TB Linux comm-central leak test build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21297
repository: comm-central
start_time: 2015-07-22T23:32:41
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-286
buildname: TB Linux comm-central build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21296
repository: comm-central
start_time: 2015-07-22T23:33:02
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-077
buildname: TB Linux x86-64 comm-central leak test build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21298
repository: comm-central
start_time: 2015-07-22T23:32:42
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-285
buildname: TB Linux x86-64 comm-central build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21308
repository: comm-central
start_time: 2015-07-23T00:22:22
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-073
buildname: TB Linux comm-central leak test build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10157
repository: try-comm-central
start_time: 2015-07-22T10:42:29
who: ewong[at]pw-wspx[dot]org
machine: t-xp32-ix-001
buildname: TB Windows XP 32-bit try-comm-central opt test mozmill
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10158
repository: try-comm-central
start_time: 2015-07-22T10:42:17
who: ewong[at]pw-wspx[dot]org
machine: t-xp32-ix-106
buildname: TB Windows XP 32-bit try-comm-central opt test xpcshell
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10159
repository: try-comm-central
start_time: 2015-07-22T10:54:45
who: ewong[at]pw-wspx[dot]org
machine: t-yosemite-r5-0075
buildname: TB Rev5 MacOSX Yosemite 10.10 try-comm-central opt test mozmill
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10160
repository: try-comm-central
start_time: 2015-07-22T10:54:53
who: ewong[at]pw-wspx[dot]org
machine: t-yosemite-r5-0045
buildname: TB Rev5 MacOSX Yosemite 10.10 try-comm-central opt test xpcshell
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10155
repository: try-comm-central
start_time: 2015-07-22T11:11:44
who: ewong[at]pw-wspx[dot]org
machine: t-w732-ix-142
buildname: TB Windows 7 32-bit try-comm-central opt test mozmill
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10156
repository: try-comm-central
start_time: 2015-07-22T11:11:37
who: ewong[at]pw-wspx[dot]org
machine: t-w732-ix-130
buildname: TB Windows 7 32-bit try-comm-central opt test xpcshell
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 15

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10153
repository: try-comm-central
start_time: 2015-07-22T09:03:14
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-367
buildname: Ubuntu VM 12.04 try-comm-central opt test mozmill
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 16

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10154
repository: try-comm-central
start_time: 2015-07-22T09:03:14
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-496
buildname: Ubuntu VM 12.04 try-comm-central opt test xpcshell
revision: 7bbe9100c842

HTTPError: HTTP Error 404: Not Found

Comment 17

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10149
repository: try-comm-central
start_time: 2015-07-21T11:37:11
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-606
buildname: Ubuntu VM 12.04 try-comm-central opt test mozmill
revision: ee480dfabb9d

HTTPError: HTTP Error 404: Not Found

Comment 18

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10141
repository: try-comm-central
start_time: 2015-07-21T09:18:16
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-1070
buildname: Ubuntu VM 12.04 try-comm-central opt test mozmill
revision: 231b91e2ca67

HTTPError: HTTP Error 404: Not Found

Comment 19

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10148
repository: try-comm-central
start_time: 2015-07-21T11:37:10
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-569
buildname: Ubuntu VM 12.04 try-comm-central opt test xpcshell
revision: ee480dfabb9d

HTTPError: HTTP Error 404: Not Found

Comment 20

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10142
repository: try-comm-central
start_time: 2015-07-21T09:18:16
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-637
buildname: Ubuntu VM 12.04 try-comm-central opt test xpcshell
revision: 231b91e2ca67

HTTPError: HTTP Error 404: Not Found

Comment 21

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10143
repository: try-comm-central
start_time: 2015-07-21T09:20:17
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-650
buildname: Ubuntu VM 12.04 try-comm-central debug test mozmill
revision: 2d8a41575458

HTTPError: HTTP Error 404: Not Found

Comment 22

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10131
repository: try-comm-central
start_time: 2015-07-21T01:26:37
who: ewong[at]pw-wspx[dot]org
machine: t-yosemite-r5-0071
buildname: TB Rev5 MacOSX Yosemite 10.10 try-comm-central opt test mozmill
revision: 58e1f70123ff

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 23

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10130
repository: try-comm-central
start_time: 2015-07-21T01:26:37
who: ewong[at]pw-wspx[dot]org
machine: t-yosemite-r5-0063
buildname: TB Rev5 MacOSX Yosemite 10.10 try-comm-central opt test xpcshell
revision: 58e1f70123ff

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 24

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10129
repository: try-comm-central
start_time: 2015-07-21T01:26:21
who: ewong[at]pw-wspx[dot]org
machine: t-snow-r4-0025
buildname: TB Rev4 MacOSX Snow Leopard 10.6 try-comm-central opt test xpcshell
revision: 58e1f70123ff

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 25

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10126
repository: try-comm-central
start_time: 2015-07-21T00:35:11
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-386
buildname: Ubuntu VM 12.04 try-comm-central opt test xpcshell
revision: 58e1f70123ff

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 26

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10125
repository: try-comm-central
start_time: 2015-07-21T00:35:10
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-464
buildname: Ubuntu VM 12.04 try-comm-central opt test mozmill
revision: 58e1f70123ff

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 27

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10128
repository: try-comm-central
start_time: 2015-07-21T00:35:10
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-686
buildname: Ubuntu VM 12.04 try-comm-central opt test mozmill
revision: e1550f9e5f8c

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 28

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10127
repository: try-comm-central
start_time: 2015-07-21T00:35:11
who: ewong[at]pw-wspx[dot]org
machine: tst-linux32-spot-468
buildname: Ubuntu VM 12.04 try-comm-central opt test xpcshell
revision: e1550f9e5f8c

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 29

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10134
repository: try-comm-central
start_time: 2015-07-21T01:29:08
who: ewong[at]pw-wspx[dot]org
machine: t-snow-r4-0095
buildname: TB Rev4 MacOSX Snow Leopard 10.6 try-comm-central opt test xpcshell
revision: e1550f9e5f8c

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 30

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10133
repository: try-comm-central
start_time: 2015-07-21T01:29:08
who: ewong[at]pw-wspx[dot]org
machine: t-yosemite-r5-0060
buildname: TB Rev5 MacOSX Yosemite 10.10 try-comm-central opt test xpcshell
revision: e1550f9e5f8c

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 31

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try-comm-central&job_id=10132
repository: try-comm-central
start_time: 2015-07-21T01:29:17
who: ewong[at]pw-wspx[dot]org
machine: t-yosemite-r5-0079
buildname: TB Rev5 MacOSX Yosemite 10.10 try-comm-central opt test mozmill
revision: e1550f9e5f8c

HTTPError: HTTP Error 404: Not Found
HTTPError: HTTP Error 404: Not Found

Comment 32

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21313
repository: comm-central
start_time: 2015-07-23T01:50:23
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-115
buildname: TB Linux comm-central build
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 33

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21327
repository: comm-central
start_time: 2015-07-23T13:19:27
who: clokep[at]gmail[dot]com
machine: bld-linux64-spot-319
buildname: TB Linux comm-central leak test build
revision: 3c43f4fdb801

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 34

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21329
repository: comm-central
start_time: 2015-07-23T13:21:26
who: clokep[at]gmail[dot]com
machine: bld-linux64-spot-137
buildname: TB Linux x86-64 comm-central leak test build
revision: 3c43f4fdb801

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 35

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21328
repository: comm-central
start_time: 2015-07-23T13:19:29
who: clokep[at]gmail[dot]com
machine: bld-linux64-spot-039
buildname: TB Linux x86-64 comm-central build
revision: 3c43f4fdb801

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 36

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21326
repository: comm-central
start_time: 2015-07-23T13:21:40
who: clokep[at]gmail[dot]com
machine: bld-linux64-spot-309
buildname: TB Linux comm-central build
revision: 3c43f4fdb801

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 37

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21317
repository: comm-central
start_time: 2015-07-23T03:02:08
who: clokep[at]gmail[dot]com
machine: bld-linux64-spot-042
buildname: TB Linux x86-64 comm-central nightly
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 38

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21314
repository: comm-central
start_time: 2015-07-23T03:02:09
who: clokep[at]gmail[dot]com
machine: bld-linux64-spot-261
buildname: TB Linux comm-central nightly
revision: bb21a5dd4d1d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 39

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21352
repository: comm-central
start_time: 2015-07-23T16:11:50
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-516
buildname: TB Linux comm-central build
revision: 3487a322b28d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 40

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21348
repository: comm-central
start_time: 2015-07-23T16:11:49
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1093
buildname: TB Linux comm-central leak test build
revision: 3487a322b28d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 41

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21350
repository: comm-central
start_time: 2015-07-23T16:11:50
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1097
buildname: TB Linux x86-64 comm-central build
revision: 3487a322b28d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 42

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21353
repository: comm-central
start_time: 2015-07-23T16:11:50
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-304
buildname: TB Linux x86-64 comm-central leak test build
revision: 3487a322b28d

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 43

[Edmund Wong (:ewong)]

Attachment: proposed patch(v1)

This went through try:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f77164f048cc

Comment 44

[Edmund Wong (:ewong)]

Attachment: proposed patch (v2)

Comment 45

[Kent James (:rkent)]

Comment on attachment 8638385 [details] [diff] [review]
proposed patch (v2)

Review of attachment 8638385 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/shell/moz.build
@@ +13,5 @@
>  
>  if CONFIG['OS_ARCH'] == 'WINNT':
>      SOURCES += ['nsMailWinIntegration.cpp']
>  
> +if CONFIG['MOZ_WIDGET_GTK']:

You have many places where you replaced the == with just a def check. Shouldn't this be instead:

if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('gtk2', 'gtk3'):

(here and various other places)?

Comment 46

[Kent James (:rkent)]

OK I picked a bad spot in the previous comment, but the question still stands. You replaced equality with gtk2 to checking for existence in a number of places. Why?

Comment 47

[Kent James (:rkent)]

Comment on attachment 8638385 [details] [diff] [review]
proposed patch (v2)

Review of attachment 8638385 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/app/Makefile.in
@@ +109,5 @@
>  libs:: $(addprefix $(DIST)/branding/,$(BRANDED_ICON_FILES))
>  	$(INSTALL) $(IFLAGS1) $^ $(DIST)/bin/chrome/icons/default
>  endif
>  
> +ifdef MOZ_WIDGET_TOOLKIT

This spot is a better example.

Comment 48

[Edmund Wong (:ewong)]

(In reply to Kent James (:rkent) from comment #45)
> Comment on attachment 8638385 [details] [diff] [review]
> proposed patch (v2)
> 
> Review of attachment 8638385 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/components/shell/moz.build
> @@ +13,5 @@
> >  
> >  if CONFIG['OS_ARCH'] == 'WINNT':
> >      SOURCES += ['nsMailWinIntegration.cpp']
> >  
> > +if CONFIG['MOZ_WIDGET_GTK']:
> 
> You have many places where you replaced the == with just a def check.
> Shouldn't this be instead:
> 
> if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('gtk2', 'gtk3'):
> 
> (here and various other places)?

MOZ_WIDGET_GTK is defined only on platforms that use either
cairo-gtk2 or cairo-gtk3, so it is sufficient (from what I
see) to just check the existence of the value.  It's actually
equivalent to what you put; but cleaner. :)

Comment 49

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21456
repository: comm-central
start_time: 2015-07-24T16:36:58
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-262
buildname: TB Linux comm-central build
revision: aeca087abe82

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 50

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21453
repository: comm-central
start_time: 2015-07-24T16:36:49
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1065
buildname: TB Linux comm-central leak test build
revision: aeca087abe82

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 51

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21454
repository: comm-central
start_time: 2015-07-24T16:36:58
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-046
buildname: TB Linux x86-64 comm-central build
revision: aeca087abe82

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 52

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21457
repository: comm-central
start_time: 2015-07-24T16:36:57
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-178
buildname: TB Linux x86-64 comm-central leak test build
revision: aeca087abe82

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 53

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21434
repository: comm-central
start_time: 2015-07-24T14:51:50
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-491
buildname: TB Linux comm-central build
revision: a77149516698

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 54

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21437
repository: comm-central
start_time: 2015-07-24T14:51:51
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1066
buildname: TB Linux x86-64 comm-central build
revision: a77149516698

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 55

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21438
repository: comm-central
start_time: 2015-07-24T14:51:55
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-098
buildname: TB Linux x86-64 comm-central leak test build
revision: a77149516698

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 56

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21388
repository: comm-central
start_time: 2015-07-24T00:51:36
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-012
buildname: TB Linux comm-central build
revision: 6962356b69b1

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 57

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21435
repository: comm-central
start_time: 2015-07-24T14:51:50
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-394
buildname: TB Linux comm-central leak test build
revision: a77149516698

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 58

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21389
repository: comm-central
start_time: 2015-07-24T00:51:39
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-099
buildname: TB Linux comm-central leak test build
revision: 6962356b69b1

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 59

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21419
repository: comm-central
start_time: 2015-07-24T03:02:48
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-274
buildname: TB Linux comm-central nightly
revision: 6962356b69b1

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 60

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21390
repository: comm-central
start_time: 2015-07-24T00:47:45
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1077
buildname: TB Linux x86-64 comm-central build
revision: 6962356b69b1

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 61

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21421
repository: comm-central
start_time: 2015-07-24T03:02:47
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-096
buildname: TB Linux x86-64 comm-central nightly
revision: 6962356b69b1

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 62

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21391
repository: comm-central
start_time: 2015-07-24T00:51:10
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-302
buildname: TB Linux x86-64 comm-central leak test build
revision: 6962356b69b1

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 63

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21374
repository: comm-central
start_time: 2015-07-24T00:40:41
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1056
buildname: TB Linux comm-central build
revision: dd68254da258

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 64

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21375
repository: comm-central
start_time: 2015-07-24T00:36:05
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-030
buildname: TB Linux comm-central leak test build
revision: dd68254da258

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 65

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21376
repository: comm-central
start_time: 2015-07-24T00:40:30
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-1050
buildname: TB Linux x86-64 comm-central build
revision: dd68254da258

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 66

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21377
repository: comm-central
start_time: 2015-07-24T00:35:52
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-436
buildname: TB Linux x86-64 comm-central leak test build
revision: dd68254da258

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 67

[Kent James (:rkent)]

As I said, my comment 45 was an error, I meant to comment (per my correction in comment 47) about using MOZ_WIDGET_TOOLKIT, such as this change:

-ifeq ($(MOZ_WIDGET_TOOLKIT),gtk2)
+ifdef MOZ_WIDGET_TOOLKIT

I see lots of code like this:

 elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':

that shows that MOZ_WIDGET_TOOLKIT is not linux-specific.

Comment 68

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8638385 [details] [diff] [review]
proposed patch (v2)

Review of attachment 8638385 [details] [diff] [review]:
-----------------------------------------------------------------

You're missing a few changes where MOZ_WIDGET_GTK2 is used in code:
<https://dxr.mozilla.org/comm-central/search?q=MOZ_WIDGET_GTK2&case=true>. The changes in nsMailComps.cpp are absolutely necessary to get the default application stuff working. The change to enable_drag_images are less clear if they're necessary (although that looks to be bug 450971).

::: mail/branding/aurora/Makefile.in
@@ +20,5 @@
>  	cp $(srcdir)/dsstore           $(DIST)/branding/dsstore
>  	cp $(srcdir)/disk.icns         $(DIST)/branding/disk.icns
>  	cp $(srcdir)/thunderbird.icns  $(DIST)/branding/thunderbird.icns
>  endif
> +ifdef MOZ_WIDGET_TOOLKIT

As rkent says, these lines are busted, since it's selecting these files for all platforms, whereas the desire is only for Linux ones.

Comment 69

[Ian Neal]

Attachment: GTK changes for TB, SM and MailNews

The only thing I wasn't sure about was whether it was worth making changes to mailnews/build/nsMailModule.cpp

Pushed to try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fc221c9a961a

Comment 70

[Ian Neal]

Attachment: GTK changes for IM

Comment 71

[Ian Neal]

Attachment: GTK changes for TB, SM and MailNews v1.1

Changes since last patch:
* Missed package-manifest entries for mozgtk* in suite/

Comment 72

[Ian Neal]

Attachment: GTK changes for IM v1.1

Changes since previous patch:
* Missed package-manifest changes for mozgtk* entries.

Comment 73

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8639044 [details] [diff] [review]
GTK changes for TB, SM and MailNews v1.1

Review of attachment 8639044 [details] [diff] [review]:
-----------------------------------------------------------------

You're missing other-licenses/branding/thunderbird/Makefile.in, but otherwise everything looks good.

Although it looks like our removed-files.in could use a bit of pruning.

Comment 74

[Ian Neal]

Attachment: GTK changes for TB, SM and MailNews v1.2 [Checked in: Comment 76 & Comment 79]

Added other-licenses changes for TB, carrying forward r=

Comment 75

[Ian Neal]

Attachment: GTK changes for IM v1.2 [Checked in: Comment 78]

Added changes in other-licenses for InstantBird

Comment 76

[Ian Neal]

Comment on attachment 8639095 [details] [diff] [review]
GTK changes for TB, SM and MailNews v1.2 [Checked in: Comment 76 & Comment 79]

https://hg.mozilla.org/comm-central/rev/ae95dbce7c48

Comment 77

[Florian Quèze [:florian]]

Comment on attachment 8639096 [details] [diff] [review]
GTK changes for IM v1.2 [Checked in: Comment 78]

Thanks!

Comment 78

[Ian Neal]

Comment on attachment 8639096 [details] [diff] [review]
GTK changes for IM v1.2 [Checked in: Comment 78]

https://hg.mozilla.org/comm-central/rev/a875b1e5aa1c

Comment 79

[Ian Neal]

Comment on attachment 8639095 [details] [diff] [review]
GTK changes for TB, SM and MailNews v1.2 [Checked in: Comment 76 & Comment 79]

Remove unneeded gtk argument:
https://hg.mozilla.org/comm-central/rev/28bda87ffa1f