1188978 - Figure out how we should expose the tab playing icon to accessibility clients

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(no longer active)]

David, I would appreciate if you could find someone to help with this.  I would be happy to introduce them to the implementation as needed.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Alex, Gijs, can one of you guys jump on this?

Comment 2

[alexander :surkov (:asurkov)]

Where can I see a demo of the tab playing icon?

Comment 3

[(no longer active)]

(In reply to alexander :surkov from comment #2)
> Where can I see a demo of the tab playing icon?

On Nightly.  Go to youtube for example.

Comment 4

[:Gijs (he/him)]

I'm a little confused what the question is here. I've not tried the functionality yet, but I read about it, and AIUI it should probably be exposed as a button (pressing it mutes/unmutes, right?) with a label that indicates the current state and what the button would do. If you already update a tooltip for this purpose, that should essentially do, AIUI. Am I missing the point?

Comment 5

[alexander :surkov (:asurkov)]

(In reply to :Gijs Kruitbosch from comment #4)
> I'm a little confused what the question is here. I've not tried the
> functionality yet, but I read about it, and AIUI it should probably be
> exposed as a button (pressing it mutes/unmutes, right?) with a label that
> indicates the current state and what the button would do.

agree

> If you already
> update a tooltip for this purpose, that should essentially do, AIUI. Am I
> missing the point?

perhaps that button should be also a live region, if the page starts playing then the button pops up making the user aware which tab is playing the sound. However it doesn't serve for notification proposes if a tab is scrolled of, that's probably not the case of most users.

Comment 6

[(no longer active)]

Comment 4 sounds about right, but my main question here is how to do this as in how to implement it.  I am not familiar with how we expose stuff to a11y clients.  I would really appreciate if one of you could help here with a patch!  :-)

One thing to note in case you want to use ARIA or something similar is that the element that renders the sound playing or muted icons is different if the tab is pinned.  This is the normal element <http://hg.mozilla.org/mozilla-central/annotate/5e8e09201617/browser/base/content/tabbrowser.xml#l5702> and this is the one for the pinned case <http://hg.mozilla.org/mozilla-central/annotate/5e8e09201617/browser/base/content/tabbrowser.xml#l5693>.

Also, when the tab is playing sound, we set a soundplaying attribute on it, and when it is muted, we set a muted attribute on it.  The tab can be muted even if it is not currently playing sound, and when both attributes are present, the muted attribute takes precedence.

Thanks!

Comment 7

[(no longer active)]

Talking to davidb and the team, this doesn't need to block.

Comment 8

[James Teh [:Jamie]]

We should probably expose this as part of the tab's a11y description in the tab bar. In addition, if we find some way of making pieces of info easily accessible for the current tab without having to focus the tab bar, we should put this there too.

Comment 9

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1188978 - Expose tab playing to accessibility clients. r=dao,mhowell

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c791df1eee78
Expose tab playing to accessibility clients. r=dao,mhowell,fluent-reviewers,flod

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c791df1eee78