Closed
Bug 1189127
Opened 10 years ago
Closed 10 years ago
Quickly entering a character after replacing text doesn't update suggestions
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
(Keywords: regression)
Attachments
(1 file)
Regression from bug 1177597. STR:
1) Enter "yahoo.com/".
2) Select all, hit backspace, then quickly hit "y".
This should show y[ahoo.com], but it doesn't because of our debounce/willSet query handling. Since we quickly set the "y" after clearing the text, the willSet handler never sees the empty string, so it treats the "y" as a deletion rather than an insertion. This is causing DomainAutocompleteTests to fail.
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8640820 -
Flags: review?(wjohnston)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8640820 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/830
Karim can take a look at this too since he just added this canAutocomplete property that we're using.
Attachment #8640820 -
Flags: review?(kbenhmida)
|
||
Updated•10 years ago
|
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8640820 -
Flags: review?(wjohnston) → review?(sleroux)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8640820 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/830
LGTM
Attachment #8640820 -
Flags: review?(kbenhmida) → review+
|
|
||
Updated•10 years ago
|
Attachment #8640820 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•