Search screen does not show on iOS9

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: st3fan, Assigned: codester)

Tracking

(Blocks: 1 bug)

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: ios9)

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
STR:

1) Navigate to some site
2) Tap the location bar
3) Start typing

Expected:

The search screen is shown. You see search results for your default search engine.

Actual:

Nothing happens. You stay on the home screen with the tiles.

Only seems to happen on iOS9. No hints in the console.
tracking-fxios: ? → +
(Assignee)

Comment 1

2 years ago
In iOS9 due to some bug `UIKeyInput` method `insertText` do not call.
I have created pull request which resolve the issue.

https://github.com/mozilla/firefox-ios/pull/715
(Assignee)

Comment 2

2 years ago
Created attachment 8632556 [details] [review]
Pull Request
(Assignee)

Updated

2 years ago
Attachment #8632556 - Flags: review?(bnicholson)
Comment on attachment 8632556 [details] [review]
Pull Request

Thanks for the pull request! On the right track, but we need to figure out a fix for this that doesn't flash the input each time a character is typed.
Attachment #8632556 - Flags: review?(bnicholson) → feedback+
Assignee: nobody → sahil.profile
Status: NEW → ASSIGNED
Comment on attachment 8632556 [details] [review]
Pull Request

Sorry, looks like the flicker issue is an existing bug on master. I'll give this another look.
Attachment #8632556 - Flags: feedback+ → review?(bnicholson)
Comment on attachment 8632556 [details] [review]
Pull Request

Seems to work well on English keyboards, though breaks Japanese as mentioned in the PR.
Attachment #8632556 - Flags: review?(bnicholson) → feedback+
(Assignee)

Comment 6

2 years ago
@brian thanks for the comments. Have not seen your comments yesterday in bugzilla. Resolved the flicker issue. I will am also looking in to japanese character issue. Will commit the changes after testing.
(Assignee)

Comment 7

2 years ago
@brian update the pull request. Fixed flicker issue and japanese character issue.
Comment on attachment 8632556 [details] [review]
Pull Request

Going to try to look at this today when I get a chance.
Attachment #8632556 - Flags: feedback+ → review?(bnicholson)
This patch is a bit more complicated than I was expecting :) I probably won't have time to do a review today, so I'll get to it early next week. Sorry for the delay!
(Assignee)

Comment 10

2 years ago
@brian. Updated the pull request to resolve commits.
Whiteboard: ios9
(Assignee)

Comment 11

2 years ago
@brian. Updated the pull request to resolve commits.
(Assignee)

Comment 12

2 years ago
Hi @brian. Updated the pull request to resolve commits.
Comment on attachment 8632556 [details] [review]
Pull Request

iOS 9 fix looks OK, though I'll keep thinking about an alternative fix to the multistage input issue. I wonder if we can considerably simplify the flicker fix, though, as mentioned in the PR. Thoughts?

Thanks for taking the time to investigate all of this!
Attachment #8632556 - Flags: review?(bnicholson) → feedback+
(Assignee)

Comment 14

2 years ago
Comment on attachment 8632556 [details] [review]
Pull Request

Hi Brian
Thanks for suggestion. I have updated the pull request. Simplified the patch. Thanks for your help
Attachment #8632556 - Flags: review?(bnicholson)
(Assignee)

Comment 15

2 years ago
@brian

Updated the pull request to resolve conflicts.
Comment on attachment 8632556 [details] [review]
Pull Request

This looks and feels great! Thanks for all the hard work, codester! :)
Attachment #8632556 - Flags: review?(bnicholson)
Attachment #8632556 - Flags: review+
Attachment #8632556 - Flags: feedback+
https://github.com/mozilla/firefox-ios/commit/f496e89a2ed85d34bb93cfd51d12b7551814f4a9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Depends on: 1189127
Depends on: 1189413
You need to log in before you can comment on or make changes to this bug.