Remove footer + Sign Out button on settings page

VERIFIED FIXED

Status

Marketplace
Consumer Pages
P2
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: chuck, Assigned: shahbaz17, Mentored)

Tracking

Avenir
Points:
1
Dependency tree / graph

Details

(Whiteboard: [good first bug])

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Blocks: 1189774
(Assignee)

Comment 1

2 years ago
i need to work on this bug
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Thanks, Assigning you to the bug.
Assignee: nobody → shahbazalam17feb
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla/fireplace/pull/1414
Status: NEW → ASSIGNED

Updated

2 years ago
Points: --- → 1
(Assignee)

Comment 4

2 years ago
Hi David..  i am new to this..  what does points - - 1 mean..  and what shall i do next
Points are units of relative estimation measurement. The tracker bug that this bug blocks marks it as one complete project. We divide the work into iterations of time based on the total point score that we determine can fit into each iteration.

It doesn't change this bug, it just should've been entered when the bug was created.

Updated

2 years ago
Priority: -- → P1

Comment 6

2 years ago
Shahbaz, You need to recheck your code as the PR failed to pass travis.
Flags: needinfo?(shahbazalam17feb)
(Assignee)

Comment 7

2 years ago
Do i need to remove footer as well as signout option from settings page?
Flags: needinfo?(shahbazalam17feb) → needinfo?(trishul.goel)
(Assignee)

Comment 8

2 years ago
https://github.com/mozilla/fireplace/pull/1426
Whiteboard: [good first bug?]

Updated

2 years ago
Flags: needinfo?(trishul.goel)

Updated

2 years ago
Priority: P1 → P2

Updated

2 years ago
Mentor: trishul.goel@gmail.com
Whiteboard: [good first bug?] → [good first bug]

Comment 9

2 years ago
Hey Shahbaz have you tried suggestion commented on PR?
Flags: needinfo?(shahbazalam17feb)
Any progress on this? If this is still unchanged in two weeks, we'll unassign it.
(Assignee)

Comment 11

2 years ago
Why i am getting these errors https://www.dropbox.com/s/wxe7in1a450v6hg/Screenshot%20from%202015-11-09%2023%3A30%3A28.png?dl=0 

Can anyone help in this ?
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Flags: needinfo?(shahbazalam17feb)
Hi David, can you please help shahbaz here?
Flags: needinfo?(vaishnav.rd) → needinfo?(ddurst)

Comment 13

2 years ago
reopened at https://github.com/mozilla/fireplace/pull/1558

Comment 14

2 years ago
Hi David can you help Shahbaz with the travis checks?
Flags: needinfo?(trishul.goel)
I don't know that I can solve that. It looks like the first failure is related to the endpoint test, but someone more knowledgeable than I should speak to that.

:shahbaz17 -- are you able to see the travis failure details? They can point you to which particular tests are failing. It could be the test is no longer accurate; if it should be accurate then it will identify the error.

Updated

2 years ago
Flags: needinfo?(shahbazalam17feb)
(Assignee)

Comment 16

2 years ago
This bug is now resolved.Pull request successfully merged and closed https://github.com/mozilla/fireplace/pull/1558
Flags: needinfo?(trishul.goel)

Comment 17

2 years ago
PR merged. Thanks Shahbaz.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(trishul.goel)
Flags: needinfo?(shahbazalam17feb)
Flags: needinfo?(ddurst)
Resolution: --- → FIXED

Comment 18

2 years ago
Hi Trishul, if you can add this here that would be great! https://wiki.mozilla.org/Marketplace/Contributing/Recognition

Comment 19

2 years ago
Verified as fixed in FF46(Win7, Android 4.2.1) and FFOS 2.6 (Flame)
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.