Closed
Bug 1189337
Opened 9 years ago
Closed 9 years ago
Remove footer + Sign Out button on settings page
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: chuck, Assigned: shahbaz17, Mentored)
References
Details
(Whiteboard: [good first bug])
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
i need to work on this bug
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Comment 2•9 years ago
|
||
Thanks, Assigning you to the bug.
Assignee: nobody → shahbazalam17feb
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Assignee | ||
Comment 3•9 years ago
|
||
https://github.com/mozilla/fireplace/pull/1414
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
Points: --- → 1
Assignee | ||
Comment 4•9 years ago
|
||
Hi David.. i am new to this.. what does points - - 1 mean.. and what shall i do next
Comment 5•9 years ago
|
||
Points are units of relative estimation measurement. The tracker bug that this bug blocks marks it as one complete project. We divide the work into iterations of time based on the total point score that we determine can fit into each iteration. It doesn't change this bug, it just should've been entered when the bug was created.
Updated•9 years ago
|
Priority: -- → P1
Shahbaz, You need to recheck your code as the PR failed to pass travis.
Flags: needinfo?(shahbazalam17feb)
Assignee | ||
Comment 7•9 years ago
|
||
Do i need to remove footer as well as signout option from settings page?
Flags: needinfo?(shahbazalam17feb) → needinfo?(trishul.goel)
Assignee | ||
Comment 8•9 years ago
|
||
https://github.com/mozilla/fireplace/pull/1426
Updated•9 years ago
|
Whiteboard: [good first bug?]
Updated•9 years ago
|
Priority: P1 → P2
Updated•9 years ago
|
Mentor: trishul.goel
Whiteboard: [good first bug?] → [good first bug]
Hey Shahbaz have you tried suggestion commented on PR?
Flags: needinfo?(shahbazalam17feb)
Comment 10•9 years ago
|
||
Any progress on this? If this is still unchanged in two weeks, we'll unassign it.
Assignee | ||
Comment 11•9 years ago
|
||
Why i am getting these errors https://www.dropbox.com/s/wxe7in1a450v6hg/Screenshot%20from%202015-11-09%2023%3A30%3A28.png?dl=0 Can anyone help in this ?
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Flags: needinfo?(shahbazalam17feb)
Comment 12•9 years ago
|
||
Hi David, can you please help shahbaz here?
Flags: needinfo?(vaishnav.rd) → needinfo?(ddurst)
Comment 13•9 years ago
|
||
reopened at https://github.com/mozilla/fireplace/pull/1558
Comment 14•9 years ago
|
||
Hi David can you help Shahbaz with the travis checks?
Flags: needinfo?(trishul.goel)
Comment 15•9 years ago
|
||
I don't know that I can solve that. It looks like the first failure is related to the endpoint test, but someone more knowledgeable than I should speak to that. :shahbaz17 -- are you able to see the travis failure details? They can point you to which particular tests are failing. It could be the test is no longer accurate; if it should be accurate then it will identify the error.
Updated•9 years ago
|
Flags: needinfo?(shahbazalam17feb)
Assignee | ||
Comment 16•9 years ago
|
||
This bug is now resolved.Pull request successfully merged and closed https://github.com/mozilla/fireplace/pull/1558
Flags: needinfo?(trishul.goel)
Comment 17•9 years ago
|
||
PR merged. Thanks Shahbaz.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(trishul.goel)
Flags: needinfo?(shahbazalam17feb)
Flags: needinfo?(ddurst)
Resolution: --- → FIXED
Comment 18•9 years ago
|
||
Hi Trishul, if you can add this here that would be great! https://wiki.mozilla.org/Marketplace/Contributing/Recognition
Comment 19•8 years ago
|
||
Verified as fixed in FF46(Win7, Android 4.2.1) and FFOS 2.6 (Flame) Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•