Closed Bug 1189459 Opened 4 years ago Closed 4 years ago

Allow generating geckoview AAR files when MOZ_APP_NAME is not 'fennec'

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

There are a few places in https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/action/package_geckolibs_aar.py where we hard-code 'fennec'.  It's not a big deal, but it does mean that fabrice's patch to add a second Fennec-like app doesn't automatically create functional geckoview and geckolibs AAR files.  Might as well fix it.
Bug 1189459 - Allow generating geckoview AAR files when MOZ_APP_NAME is not 'fennec'. r?gps

This just allows a little versatility for consumers such as b2gdroid,
which are Fennec-like but don't have MOZ_APP_NAME=fennec.

I elected to pass appname as a parameter rather than modify the
existing distdir because I expect to want to differentiate, in some
way, the output AAR files based on the underlying name.  That is, in
future we might generate geckoview-fennec-VERSION.aar and
geckolibs-b2gdroid-VERSION.aar, or stuff the name into the Ivy version
information, or...

This also fixes a typo in one of the JarFinder instantiations.
Attachment #8641224 - Flags: review?(gps)
gps: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b892ecb65f3 successfully builds geckoview AAR for b2gdroid, so I'm pretty confident this is doing good things.
Attachment #8641224 - Flags: review?(gps) → review+
Comment on attachment 8641224 [details]
MozReview Request: Bug 1189459 - Allow generating geckoview AAR files when MOZ_APP_NAME is not 'fennec'. r?gps

https://reviewboard.mozilla.org/r/14447/#review13211

Ship It!
url:        https://hg.mozilla.org/integration/fx-team/rev/fffe3ac33207713a9d71fcddadeeb938e6221a2a
changeset:  fffe3ac33207713a9d71fcddadeeb938e6221a2a
user:       Nick Alexander <nalexander@mozilla.com>
date:       Thu Jul 30 11:50:44 2015 -0700
description:
Bug 1189459 - Allow generating geckoview AAR files when MOZ_APP_NAME is not 'fennec'. r=gps

This just allows a little versatility for consumers such as b2gdroid,
which are Fennec-like but don't have MOZ_APP_NAME=fennec.

I elected to pass appname as a parameter rather than modify the
existing distdir because I expect to want to differentiate, in some
way, the output AAR files based on the underlying name.  That is, in
future we might generate geckoview-fennec-VERSION.aar and
geckolibs-b2gdroid-VERSION.aar, or stuff the name into the Ivy version
information, or...

This also fixes a typo in one of the JarFinder instantiations.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/fffe3ac33207
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 42 → mozilla42
You need to log in before you can comment on or make changes to this bug.