Closed Bug 1189548 Opened 5 years ago Closed 5 years ago
Pasting text highlights all of URL bar text
47 bytes, text/x-github-pull-request
|Details | Review|
STR: 1) Tap URL bar. 2) Paste "yah". You should see yah[oo.com/], where only the completion is highlighted. Instead, we see [yahoo.com/].
(In reply to Brian Nicholson (:bnicholson) from comment #0) > STR: > 1) Tap URL bar. > 2) Paste "yah". Sorry, step 1 should have been "Long press URL bar". This happens when using the URL bar context menu, not the UITextField Paste.
The fix looks fine but DomainAutocompleteTests and testURLBarContextMenu in SearchTests still fail for me.
(In reply to Emily Toop (:fluffyemily) from comment #3) > The fix looks fine but DomainAutocompleteTests and testURLBarContextMenu in > SearchTests still fail for me. I ran the tests on iPhone 6, 6 Plus and 5S
Those should be fixed in bug 1189127; can you try with that PR applied?
Bug 1189127 landed, and I rebased the PR. Everything should be working now with this last fix.
Attachment #8641352 - Flags: review?(etoop) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.