Closed Bug 1189583 Opened 4 years ago Closed 4 years ago

[Nexus 4] Add support for the blobfree build

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hobinjk, Assigned: hobinjk)

References

Details

Attachments

(3 files, 1 obsolete file)

49 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
51 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
50 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
Like bug 1172912, add the support into gonk-misc/Android.mk and the Nexus 4's device.mk.
Attached file device-mako PR (obsolete) —
Attachment #8649600 - Flags: review?(lissyx+mozillians)
Attached file gonk-misc PR
Attachment #8649601 - Flags: review?(lissyx+mozillians)
Attached file b2g-installer PR
Attachment #8649602 - Flags: review?(lissyx+mozillians)
The overview of the changes is that gonk-misc gets support for specifying multiple sources of blobs. device-mako specifies those blobs. gonk-misc also learns how to rename fstab.mako to be recovery.fstab. gonk-misc passes the mkbootimg args into cmdline-fs.txt, which b2g-installer reads and employs. b2g-installer now also deals with the double spaces the mako's system.img cmdline has.
Nice. That mostly looks all good. I have commented on a few nits/enhancements that might be worthwhile. Sadly, I don't think I'll be able to make it to review quickly before being a couple of days on PTO: need to get a tree to build, need to get a device to test.
Wait, james, this is a PR against Jelly Bean. I think you might want only KK? At least I'm going to try on a KK build.
Flags: needinfo?(hobinjk)
(In reply to Alexandre LISSY :gerard-majax from comment #6)
> Wait, james, this is a PR against Jelly Bean. I think you might want only
> KK? At least I'm going to try on a KK build.

This is based on the nexus-4.xml manifest (jb), I will make sure it also works on nexus-4-kk.
Flags: needinfo?(hobinjk)
Attachment #8649600 - Attachment is obsolete: true
Attachment #8649600 - Flags: review?(lissyx+mozillians)
Attachment #8650044 - Flags: review?(lissyx+mozillians)
Blocks: 1189584
Assignee: nobody → hobinjk
Comment on attachment 8649601 [details] [review]
gonk-misc PR

Looks good, I could produce blobfree for Z3c KK and Nexus 4 KK.
Attachment #8649601 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8649602 [details] [review]
b2g-installer PR

Good but you might want to increase the 5 secs timeout of rebooting to fastboot, it seemed a bit too small.
Attachment #8649602 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8650044 [details] [review]
device-mako PR based on nexus-4-kk

That works great, we just have to change the ro.build.id matching. Something like: [ "KOT49H", "KTU48P" ] should be good.
Flags: needinfo?(hobinjk)
Attachment #8650044 - Flags: review?(lissyx+mozillians) → review+
https://github.com/mozilla-b2g/device-mako/commit/aea6908cd694b4ef9e7ad64a930d52eab6ab1e17
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
This is resolved, clearing needinfo.
Flags: needinfo?(hobinjk)
You need to log in before you can comment on or make changes to this bug.