1189583 - [Nexus 4] Add support for the blobfree build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[James Hobin [:hobinjk]]

Like bug 1172912, add the support into gonk-misc/Android.mk and the Nexus 4's device.mk.

Comment 1

[James Hobin [:hobinjk]]

Attachment: device-mako PR

Comment 2

[James Hobin [:hobinjk]]

Attachment: gonk-misc PR

Comment 3

[James Hobin [:hobinjk]]

Attachment: b2g-installer PR

Comment 4

[James Hobin [:hobinjk]]

The overview of the changes is that gonk-misc gets support for specifying multiple sources of blobs. device-mako specifies those blobs. gonk-misc also learns how to rename fstab.mako to be recovery.fstab. gonk-misc passes the mkbootimg args into cmdline-fs.txt, which b2g-installer reads and employs. b2g-installer now also deals with the double spaces the mako's system.img cmdline has.

Comment 5

[:gerard-majax]

Nice. That mostly looks all good. I have commented on a few nits/enhancements that might be worthwhile. Sadly, I don't think I'll be able to make it to review quickly before being a couple of days on PTO: need to get a tree to build, need to get a device to test.

Comment 6

[:gerard-majax]

Wait, james, this is a PR against Jelly Bean. I think you might want only KK? At least I'm going to try on a KK build.

Comment 7

[James Hobin [:hobinjk]]

(In reply to Alexandre LISSY :gerard-majax from comment #6)
> Wait, james, this is a PR against Jelly Bean. I think you might want only
> KK? At least I'm going to try on a KK build.

This is based on the nexus-4.xml manifest (jb), I will make sure it also works on nexus-4-kk.

Comment 8

[James Hobin [:hobinjk]]

Attachment: device-mako PR based on nexus-4-kk

Comment 9

[:gerard-majax]

Comment on attachment 8649601 [details] [review]
gonk-misc PR

Looks good, I could produce blobfree for Z3c KK and Nexus 4 KK.

Comment 10

[:gerard-majax]

Comment on attachment 8649602 [details] [review]
b2g-installer PR

Good but you might want to increase the 5 secs timeout of rebooting to fastboot, it seemed a bit too small.

Comment 11

[:gerard-majax]

https://github.com/mozilla-b2g/gonk-misc/commit/e9e2923fd6cab93cf88b4b9ada82225e44fe6635

Comment 12

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-installer/commit/df71bfd2887186193585cf73f8a6f4df82026a2c

Comment 13

[:gerard-majax]

Comment on attachment 8650044 [details] [review]
device-mako PR based on nexus-4-kk

That works great, we just have to change the ro.build.id matching. Something like: [ "KOT49H", "KTU48P" ] should be good.

Comment 14

[:gerard-majax]

https://github.com/mozilla-b2g/device-mako/commit/aea6908cd694b4ef9e7ad64a930d52eab6ab1e17

Comment 15

[James Hobin [:hobinjk]]

This is resolved, clearing needinfo.