1189624 - Have AudioSink listen to MediaQueue events to know whether to continue playback

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Bug 1188257 add push, pop and finish events to MediaQueue. AudioSink can listener to these events to know whether to continue playback without requiring MDSM to call AudioSink::NotifyData() explicitly.

This improve autonomy of AudioSink and reduce dependency on MDSM.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9465cd498815

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Try is green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=992ca7f6ee87

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1189624 - Have AudioSink listen to MediaQueue events to know whether to continue playback.

Bug 1189624 - Have AudioSink listen to MediaQueue events to know whether to continue playback.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8644093 [details]
MozReview Request: Bug 1189624 - Have AudioSink listen to MediaQueue events to know whether to continue playback.

https://reviewboard.mozilla.org/r/15219/#review13639

Ship It!

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f14633949932

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f14633949932