1189759 - Add tab sound icon to subject tab in tabs list drop-down

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[IU]

For people with a large number of tabs per window, it would be great if the following enhancement could be made:

If reasonably easy to do, it would be great if the tab sound icon could also appear in the tabs list drop-down, for the respective tab playing audio (preferably at the end of the tab name)

For this particular case, no muting functionality is required -- just the icon -- so someone can quickly locate, switch to the tab and deal with it.

Comment 1

[(no longer active)]

This is a reasonable feature request, I think, but it should not block shipping the current audio indicators.

Comment 2

[(no longer active)]

Attachment: Add sound playing and muted icons to the all tabs menu; r=jaws

Comment 3

[(no longer active)]

Attachment: Screenshot

I'd like to get a review on the UI before finishing up the patch and make it ready for review.  (I need to do some more testing on Windows and Linux before the patch is ready for review...)

Comment 4

[(no longer active)]

Note that these menu items will behave like normal items, which means that the sound playing icon cannot be clicked on individually.  Activating the menu will focus the noisy tab as usual.

Comment 5

[(no longer active)]

(In reply to :Ehsan Akhgari (not reviewing patches, not reading bugmail, needinfo? me!) from comment #1)
> This is a reasonable feature request, I think, but it should not block
> shipping the current audio indicators.

Actually, thinking about this more, this may be a nice way to address bug 1186633, or at least part of a solution for that, so this should block.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8642067 [details] [diff] [review]
Add sound playing and muted icons to the all tabs menu; r=jaws

Review of attachment 8642067 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by feedback. Most of the patch looks fine.

::: toolkit/content/widgets/menu.xml
@@ +222,5 @@
>        </xul:hbox>
>      </content>
>    </binding>
>  
> +  <binding id="menuitem-iconic-right" extends="chrome://global/content/bindings/menu.xml#menuitem">

Since this new binding allows icons on both the left (via 'image' attribute) and right (via 'rightimage' attribute), I think this name should be "menuitem-iconic-both", "menuitem-iconic-leftright", or "menuitem-iconic-startend".

Further, can we adjust the attributes to "startimage" and "endimage" instead of "image" and "rightimage", respectively? The downside to this is breaking the consistency of specifying "image" for the left image on these bindings.

Comment 7

[Stephen Horlander [:shorlander]]

Comment on attachment 8642068 [details]
Screenshot

LGTM. Is that the smaller icon? Probably have enough space there for the bigger one.

Comment 8

[(no longer active)]

(In reply to Stephen Horlander [:shorlander] from comment #7)
> Comment on attachment 8642068 [details]
> Screenshot
> 
> LGTM. Is that the smaller icon? Probably have enough space there for the
> bigger one.

Yeah it is the smaller icon.  I'll see if the bigger one fits there (I think it should.)

Comment 9

[(no longer active)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Since this new binding allows icons on both the left (via 'image' attribute)
> and right (via 'rightimage' attribute), I think this name should be
> "menuitem-iconic-both", "menuitem-iconic-leftright", or
> "menuitem-iconic-startend".

OK.

> Further, can we adjust the attributes to "startimage" and "endimage" instead
> of "image" and "rightimage", respectively? The downside to this is breaking
> the consistency of specifying "image" for the left image on these bindings.

I'm fine with "endimage" but I don't think we have a good reason to change "startimage", since that might break add-on code, and the majority of menu items only have one image, so startimage for them is not even a good name.

Do you agree?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Ok, I'm fine with "image" and "endimage" being that "image" would then imply it is not at the end and therefore possibly at the start.

Comment 11

[(no longer active)]

Attachment: Final screenshot (OSX)

Comment 12

[(no longer active)]

Attachment: Final screenshot (Windows Classic)

Comment 13

[(no longer active)]

Attachment: Final screenshot (Windows 7)

Comment 14

[(no longer active)]

Attachment: Final screenshot (Ubuntu)

Comment 15

[(no longer active)]

Attachment: Part 1: Implement <xul:menuitem endimage> as a way to display an image at the end of a menu item

Comment 16

[(no longer active)]

Attachment: Part 2: Add sound playing and muted icons to the all tabs menu; r=jaws

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfe28c09bed9
https://hg.mozilla.org/integration/mozilla-inbound/rev/de03e403128c

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfe28c09bed9
https://hg.mozilla.org/mozilla-central/rev/de03e403128c

Comment 19

[IU]

Thanks for implementing this. Working without issues.

Comment 20

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed using latest Aurora 42.0a2 (buildID: 20150917004025).