1189915 - Add privacy policy link to Settings

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Richard Newman [:rnewman]]

We need one of these, linking to:

https://www.mozilla.org/privacy/firefox/

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

making up for lost time jumping from a plane LOL

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8642100 [details] [review]
PR

Two comments on the PR.

Comment 3

[Robin Andersen [:tecgirl]]

Comment on attachment 8642100 [details] [review]
PR

1) The webview loads with no way to go back—my biggest issue ATM (IDC what Chrome does). The interaction feels weird that it loads in the browser with the URL bar and bottom nav. We could either enable the back arrow to go back to Settings or open in an overlay with a close [x].
2) The License could use some formatting.
a. 'FIREFOX FOR IOS' should be 'Firefox for iOS' 
b. "Licenses".  Let's find a way to break them up, endless scroll is endless.

Comment 4

[Robin Andersen [:tecgirl]]

Ignore the above comments, they should have gone on bug 1179422

Comment 5

[Robin Andersen [:tecgirl]]

Comment on attachment 8642100 [details] [review]
PR

The user has no way to go back! So they're left with using the tab tray to navigate elsewhere. If possible, enable the back button.

Comment 6

[Richard Newman [:rnewman]]

Both Licenses and Privacy Policy should use the same page-loading technique that Sign In uses. Should be a five-minute fix, Bryan.

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8642100 [details] [review]
PR

Left some additional comments on the changes and animation glitch

Comment 8

[Stephan Leroux [:sleroux]]

Comment on attachment 8642100 [details] [review]
PR

Just one comment about the string but other than that LGTM!