Remove nsIChannel CorsMode flag and set Request.mode based on nsILoadInfo securityFlags instead

NEW
Unassigned

Status

()

Core
DOM: Service Workers
P3
minor
3 years ago
6 months ago

People

(Reporter: bkelly, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
Once bug 1182535 updates enough of the network callsites we should switch the ServiceWorkerManager code to using nsILoadInfo::GetSecurityFlags() to set the Request.mode value.  Once this is done we can remove the nsIChannel CorsMode flag.  The new nsILoadInfo securityFlags is more robust and being integrated with the rest of the tree.

For example, the securityFlags will actually reflect same-origin policies which are currently not reflected in actual values on CorsMode.

Note, we will still need to exempt the mode for document nsIContentPolicy values since navigations need to be same-origin, but the security flags won't reflect that.
(Reporter)

Comment 1

3 years ago
I have a patch in bug 1184967 that adds the conversion from securityFlags.

Updated

3 years ago
Blocks: 1182120
Ben said elsewhere that this is nice but not entirely necessary for the initial shipping of SW.  He noted some changes that he's made and others still needed but I didn't catch them quickly enough to type them here.
Blocks: 1173500
No longer blocks: 1059784

Updated

3 years ago
Blocks: 1182113

Updated

3 years ago
No longer blocks: 1182113
(Reporter)

Comment 3

2 years ago
This is a compat issue because the legacy code paths don't reliably provide the correct FetchEvent.request values.
Blocks: 1226983
No longer blocks: 1173500

Updated

6 months ago
Severity: normal → minor
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.