Closed Bug 1189985 Opened 10 years ago Closed 10 years ago

Crash when rotating top sites panel

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: bnicholson, Assigned: fluffyemily)

Details

(Keywords: crash)

Attachments

(1 file)

Pull request
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
STR: 1) Have 11+ top site tiles. 2) Go to any page that's not about:home. 3) Close and reopen the browser to restore to that page. 4) Rotate the phone to landscape. 5) Tap the URL bar. 6) Rotate the phone to portrait.
Very similar to bug 1186148. Stack: Modified rows: 0. 2015-07-31 16:12:15.498 Client[76437:4909158] *** Assertion failure in -[UICollectionViewData validateLayoutInRect:], /SourceCache/UIKit_Sim/UIKit-3347.44.2/UICollectionViewData.m:426 2015-07-31 16:12:15.502 Client[76437:4909158] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'UICollectionView received layout attributes for a cell with an index path that does not exist: <NSIndexPath: 0xc000000000050016> {length = 2, path = 0 - 10}' *** First throw call stack: ( 0 CoreFoundation 0x000000010c35cc65 __exceptionPreprocess + 165 1 libobjc.A.dylib 0x000000010b884bb7 objc_exception_throw + 45 2 CoreFoundation 0x000000010c35caca +[NSException raise:format:arguments:] + 106 3 Foundation 0x000000010b49998f -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195 4 UIKit 0x000000010d69468b __45-[UICollectionViewData validateLayoutInRect:]_block_invoke + 1125 5 UIKit 0x000000010d693d9d -[UICollectionViewData validateLayoutInRect:] + 3092 6 UIKit 0x000000010d657850 -[UICollectionView layoutSubviews] + 194 7 UIKit 0x000000010d0b39eb -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 536 8 QuartzCore 0x000000010ceaeed2 -[CALayer layoutSublayers] + 146 9 QuartzCore 0x000000010cea36e6 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 380 10 UIKit 0x000000010d0a7635 -[UIView(Hierarchy) layoutBelowIfNeeded] + 607 11 UIKit 0x000000010d19441e -[UINavigationController _layoutViewController:] + 1135 12 UIKit 0x000000010d18bb51 -[UINavigationController _repositionPaletteWithNavigationBarHidden:duration:shouldUpdateNavigationItems:] + 370 13 UIKit 0x000000010d192181 -[UINavigationController _updateBarsForCurrentInterfaceOrientation] + 79 14 UIKit 0x000000010d19ab11 __84-[UINavigationController willTransitionToTraitCollection:withTransitionCoordinator:]_block_invoke + 528 15 UIKit 0x000000010d7835ae -[_UIViewControllerTransitionCoordinator _applyBlocks:releaseBlocks:] + 217 16 UIKit 0x000000010d780ace -[_UIViewControllerTransitionContext __runAlongsideAnimations] + 139 17 UIKit 0x000000010d4ac10e __58-[_UIWindowRotationAnimationController animateTransition:]_block_invoke + 58 18 UIKit 0x000000010d0ac3e2 +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 473 19 UIKit 0x000000010d0ac637 +[UIView(UIViewAnimationWithBlocks) animateWithDuration:delay:options:animations:completion:] + 57 20 UIKit 0x000000010d4ac090 -[_UIWindowRotationAnimationController animateTransition:] + 408 21 UIKit 0x000000010d084a09 -[UIWindow _rotateToBounds:withAnimator:transitionContext:] + 761 22 UIKit 0x000000010d086c77 -[UIWindow _rotateWindowToOrientation:updateStatusBar:duration:skipCallbacks:] + 1741 23 UIKit 0x000000010d0875ba -[UIWindow _setRotatableClient:toOrientation:applyTransformToWindow:updateStatusBar:duration:force:isRotating:] + 559 24 UIKit 0x000000010d08652e -[UIWindow _setRotatableClient:toOrientation:updateStatusBar:duration:force:isRotating:] + 116 25 UIKit 0x000000010d0864b4 -[UIWindow _setRotatableClient:toOrientation:updateStatusBar:duration:force:] + 36 26 UIKit 0x000000010d086361 -[UIWindow _setRotatableViewOrientation:updateStatusBar:duration:force:] + 122 27 UIKit 0x000000010d0853fe __57-[UIWindow _updateToInterfaceOrientation:duration:force:]_block_invoke + 98 28 UIKit 0x000000010d08534e -[UIWindow _updateToInterfaceOrientation:duration:force:] + 391 29 UIKit 0x000000010d085790 -[UIWindow _updateInterfaceOrientationFromDeviceOrientation:] + 316 30 CoreFoundation 0x000000010c32c54c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12 31 CoreFoundation 0x000000010c22aa04 _CFXNotificationPost + 2484 32 Foundation 0x000000010b3db968 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66 33 UIKit 0x000000010d2ace19 -[UIDevice setOrientation:animated:] + 282 34 UIKit 0x000000010d048007 -[UIApplication handleEvent:withNewEvent:] + 1507 35 UIKit 0x000000010d04849a -[UIApplication sendEvent:] + 79 36 UIKit 0x000000010d033b4f _UIApplicationHandleEvent + 593 37 GraphicsServices 0x000000011031638c _PurpleEventCallback + 756 38 GraphicsServices 0x0000000110315e74 PurpleEventCallback + 35 39 CoreFoundation 0x000000010c2906a9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41 40 CoreFoundation 0x000000010c29061b __CFRunLoopDoSource1 + 475 41 CoreFoundation 0x000000010c285e68 __CFRunLoopRun + 2200 42 CoreFoundation 0x000000010c285366 CFRunLoopRunSpecific + 470 43 GraphicsServices 0x0000000110314a3e GSEventRunModal + 161 44 UIKit 0x000000010d0338c0 UIApplicationMain + 1282 45 Client 0x0000000109c33e27 main + 1047 46 libdyld.dylib 0x000000010efda145 start + 1 )
Severity: normal → critical
Keywords: crash
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request —
Attachment #8643647 - Flags: review?(bnicholson)
Comment on attachment 8643647 [details] [review] Pull request Seems to work well. Yay for tests!
Attachment #8643647 - Flags: review?(bnicholson) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: