1190008 - Get Vaani into the current B2G build infrastructure and enable the prefs for platform support.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug is to get Vaani using sparkbot to pull in the app and then work with the latest spark.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1) Looking at the spark bot stuff, it seems like we need a prebuilt app that we can pull in.  I think the change is simple enough once we host a webapp somewhere (marketplace or otherwise); I would suggest placing the webapp in the marketplace.  In any cases, we will also want to keep track of the version (git hash) so we can keep track which builds have which bugs.

2) we need to enable the web speech api
media.webspeech.recognition.enable 	boolean 	true
media.webspeech.recognition.force_enable 	boolean 	true
media.webspeech.synth.enabled 	boolean 	true

3)I'm unsure of configure.in portion right now :
MOZ_WEBSPEECH_MODELS=1
MOZ_WEBSPEECH_POCKETSPHINX=1

Comment 2

[Reza Akhavan [:jedireza]]

I don't think we need to worry about #2 and #3. Those were only to get these features working in Firefox desktop.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hrm , ok.

To note for 1: if we do it else where I believe we have to do this bit : https://developer.mozilla.org/en-US/Marketplace/Options/Self_publishing

If Vaani was a hosted webapp, I figured it out already...
Trying to figure out the packaged app bit.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ah.  I see now.  if it was a webapp, the simple thing is to add it in this list : 
https://github.com/mozilla-b2g/gaia/blob/master/distros/spark/remote.list

Since it's a privileged app, the built app (ie the build directory) has to reside here : 
https://github.com/mozilla-b2g/gaia/tree/master/distros/spark/apps

That's what spark-bot does.  It makes the build and then places the updated app there.
https://github.com/spark-bot/gaia

So.  Now I'm confused where spark-bot resides.

Side note: Transformer's actually had Spark bots : http://tfwiki.net/wiki/Sparkbot

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Spark bot lives here : https://github.com/fxos-eng/spark

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Patch to add vaani into spark-bot

Spark bot is still run manually after logging into the spark-bot account.
drs is going on PTO, we will be working on getting spark-bot on a cron job soon.  

Probably even better would be using Taskcluster to handle the task at some point in the near future.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: need access to mozilla/vaani for both myself ( https://github.com/nhirata ) and spark-bot ( https://github.com/spark-bot )

Comment 8

[kdavis]

This is not the droid you're looking for; Reza is your man.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Also to note, if you want to get the app into gaia yourselves:
1) you can just build the app
2) put the build items from Vaani into a Vaani folder located : https://github.com/mozilla-b2g/gaia/tree/master/distros/spark/apps
ex. https://github.com/nhirata/gaia/commit/745659cd3e15daf21b2ccacbeb9c73a245f94167
3) make a spark gaia build, ex : GAIA_DISTRIBUTION_DIR=distros/spark  MOZILLA_OFFICIAL=1 PRODUCTION=1 make reset-gaia

Comment 10

[Reza Akhavan [:jedireza]]

Naoki, I've added you and spark-bot as collaborators to the Vaani repo. I'm not a repo owner so I was unable to simply add you to the "Speech Recognition and Synthesis" team.

The patch you submitted for spark-bot lgtm.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Doug is on PTO.  I think I would rather wait for him before we pushed this patch into the repo.  Will look into setting up a cronjob and/or taskcluster work for the remainder part.  Splitting off this part into a separate bug.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

split to bug 1190573 for investigating cronjob/taskcluster integration for Sparkbot.

Comment 13

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8642197 [details] [review]
Patch to add vaani into spark-bot

See my comment on the PR.

We should not really be adding more stuff to the Spark distro, but since we don't have a solution to pulling in remotely hosted apps without it, this is acceptable for now.

Please file a follow-up for getting this pulled into the base Gaia build.

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

modified PR some.  Not sure if you want me to extend to completely everything?

Also we need a "go" from the Vaani team to get the build in.

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

We'll need the go from you in order to push this forward.

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 8642197 [details] [review]
Patch to add vaani into spark-bot

reflagging after changes have been made and squashed.

Comment 17

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8642197 [details] [review]
Patch to add vaani into spark-bot

Please fix `REPO` -> `REMOTE`.

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Patch fixed and PR updated w/ squash.
https://github.com/fxos-eng/spark/pull/2

Comment 19

[Doug Sherk (:drs) (inactive)]

Attachment: Add Vaani to Spark Bot.

Unbitrotting this for Naoki, carrying my r+.

Comment 20

[Doug Sherk (:drs) (inactive)]

https://github.com/fxos-eng/spark/commit/9ab9e717cbc44526118c1cbb5bce5c44962c54ce

Comment 21

[Reza Akhavan [:jedireza]]

Vaani should not be released on the dogfood channel yet.

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] nhirata:add_vaani > mozilla-b2g:master

Comment 23

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Adding vaani PR

making this a manual PR to get vaani in

Comment 24

[Reza Akhavan [:jedireza]]

Comment on attachment 8662723 [details] [review]
Adding vaani PR

Based on Vaani not shipping in 2.5, this is a no-go.

Comment 25

[BMO Automation]

Firefox OS is not being worked on