Closed
Bug 1190128
Opened 9 years ago
Closed 7 years ago
A tab restored from History -> Recently Closed Tabs isn't added to CtrlTab list
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1292049
People
(Reporter: sergroj, Unassigned)
Details
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Firefox/38.0 Build ID: 20150624141534 Steps to reproduce: Resore a tab from History -> Recently Closed Tabs menu. Press Ctrl+Tab, release it. Press Ctrl+Tab again. Actual results: Another tab is selected. Expected results: The tab restored from Recently Closed Tabs should be selected.
Reporter | ||
Updated•9 years ago
|
Component: Untriaged → Tabbed Browser
Reporter | ||
Comment 1•9 years ago
|
||
Found the exact cause: browser\components\sessionstore\SessionStore.jsm - undoCloseTab just assigns tabbrowser.selectedTab, but doesn't set lastAccessed for the tab.
Version: 39 Branch → 40 Branch
Reporter | ||
Updated•9 years ago
|
Component: Tabbed Browser → Session Restore
Priority: -- → P5
Reporter | ||
Updated•9 years ago
|
Priority: P5 → P1
Reporter | ||
Comment 2•9 years ago
|
||
Forgot to mention browser.ctrlTab.previews must be true
Comment 3•7 years ago
|
||
(In reply to Sergey Rozhenko from comment #1) > Found the exact cause: > browser\components\sessionstore\SessionStore.jsm - undoCloseTab just assigns > tabbrowser.selectedTab, but doesn't set lastAccessed for the tab. However, undoCloseTab calls restoreTab: https://dxr.mozilla.org/mozilla-central/rev/71224049c0b52ab190564d3ea0eab089a159a4cf/browser/components/sessionstore/SessionStore.jsm#2387 Which then seems to set lastAccessed: https://dxr.mozilla.org/mozilla-central/rev/71224049c0b52ab190564d3ea0eab089a159a4cf/browser/components/sessionstore/SessionStore.jsm#3527-3529 So perhaps there's something else going on? Of course if you've already fixed this in an addon by setting lastAccessed in undoCloseTab, then I must be misreading the code. :-)
Comment 4•7 years ago
|
||
Radar'ing this to Dão, who knows about the ctrl-tab previews. Dão, any ideas what's going on here based on the comments below? (also moving components and resetting the priority.)
Component: Session Restore → Tabbed Browser
Flags: needinfo?(dao+bmo)
Priority: P1 → --
Updated•7 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(dao+bmo)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•