1190128 - A tab restored from History -> Recently Closed Tabs isn't added to CtrlTab list

Status: RESOLVED DUPLICATE of bug 1292049

(Firefox :: Tabbed Browser, defect)

Description

[Sergey Rozhenko]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150624141534

Steps to reproduce:

Resore a tab from History -> Recently Closed Tabs menu.
Press Ctrl+Tab, release it.
Press Ctrl+Tab again.


Actual results:

Another tab is selected.


Expected results:

The tab restored from Recently Closed Tabs should be selected.

Comment 1

[Sergey Rozhenko]

Found the exact cause:
browser\components\sessionstore\SessionStore.jsm - undoCloseTab just assigns tabbrowser.selectedTab, but doesn't set lastAccessed for the tab.

Comment 2

[Sergey Rozhenko]

Forgot to mention browser.ctrlTab.previews must be true

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to Sergey Rozhenko from comment #1)
> Found the exact cause:
> browser\components\sessionstore\SessionStore.jsm - undoCloseTab just assigns
> tabbrowser.selectedTab, but doesn't set lastAccessed for the tab.

However, undoCloseTab calls restoreTab:

https://dxr.mozilla.org/mozilla-central/rev/71224049c0b52ab190564d3ea0eab089a159a4cf/browser/components/sessionstore/SessionStore.jsm#2387

Which then seems to set lastAccessed:

https://dxr.mozilla.org/mozilla-central/rev/71224049c0b52ab190564d3ea0eab089a159a4cf/browser/components/sessionstore/SessionStore.jsm#3527-3529

So perhaps there's something else going on?  Of course if you've already fixed this in an addon by setting lastAccessed in undoCloseTab, then I must be misreading the code. :-)

Comment 4

[:Gijs (out for now; he/him)]

Radar'ing this to Dão, who knows about the ctrl-tab previews. Dão, any ideas what's going on here based on the comments below?

(also moving components and resetting the priority.)