Closed
Bug 1190172
Opened 9 years ago
Closed 9 years ago
Clean up nsHTMLEditor::SplitStyleAbovePoint, ClearStyle, NodeIsProperty, RelativeFontChangeOnTextNode, PromoteInlineRange, etc.
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(12 files, 12 obsolete files)
|
13.91 KB,
patch
|
Details | Diff | Splinter Review | |
|
8.60 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.48 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.39 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.16 KB,
patch
|
Details | Diff | Splinter Review | |
|
15.52 KB,
patch
|
Details | Diff | Splinter Review | |
|
9.74 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.26 KB,
patch
|
Details | Diff | Splinter Review | |
|
8.73 KB,
patch
|
Details | Diff | Splinter Review | |
|
17.22 KB,
patch
|
Details | Diff | Splinter Review | |
|
6.40 KB,
patch
|
Details | Diff | Splinter Review | |
|
13.00 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8643731 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8643732 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8643733 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8643734 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8643735 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Attachment #8643736 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Attachment #8643737 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Attachment #8643738 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 9•9 years ago
|
||
Attachment #8643739 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 10•9 years ago
|
||
Attachment #8643742 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 11•9 years ago
|
||
Attachment #8643743 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 12•9 years ago
|
||
Attachment #8643744 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 13•9 years ago
|
||
|
||
Comment 14•9 years ago
|
||
Comment on attachment 8643731 [details] [diff] [review]
Part 1 -- Clean up nsHTMLEditor::SplitStyleAbovePoint
Ugh, these patches seem to be megapatches with other unrelated stuff... They're impossible to review using Splinter. I'll do some cursory reviews but won't give unimportant nits. :-)
Attachment #8643731 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643732 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643733 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643734 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643735 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643736 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643737 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643738 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643739 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643742 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643743 -
Flags: review?(ehsan) → review+
|
|
||
Updated•9 years ago
|
Attachment #8643744 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 15•9 years ago
|
||
Attachment #8643731 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 16•9 years ago
|
||
Attachment #8643732 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 17•9 years ago
|
||
Attachment #8643733 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 18•9 years ago
|
||
Attachment #8643734 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 19•9 years ago
|
||
Attachment #8643735 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 20•9 years ago
|
||
Attachment #8643736 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 21•9 years ago
|
||
Attachment #8643737 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 22•9 years ago
|
||
Attachment #8643738 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 23•9 years ago
|
||
Attachment #8643739 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 24•9 years ago
|
||
|
|
Assignee | |
Comment 25•9 years ago
|
||
Attachment #8643742 -
Attachment is obsolete: true
Attachment #8643743 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 26•9 years ago
|
||
Attachment #8643744 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 27•9 years ago
|
||
Checkin instructions at bug 1191356 comment 20.
Keywords: checkin-needed
|
||
Comment 28•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc8d15277839
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd1510062322
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ebd82b3c97e
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a900f9ebc76
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8ae8039c7ad
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5e7a733fdbc
https://hg.mozilla.org/integration/mozilla-inbound/rev/77393145e701
https://hg.mozilla.org/integration/mozilla-inbound/rev/f349334cc957
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c671a3cf1d
https://hg.mozilla.org/integration/mozilla-inbound/rev/19fbefce0e94
https://hg.mozilla.org/integration/mozilla-inbound/rev/64d71b941c15
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f3002536fe4
Keywords: checkin-needed
|
||
Comment 29•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc8d15277839
https://hg.mozilla.org/mozilla-central/rev/cd1510062322
https://hg.mozilla.org/mozilla-central/rev/3ebd82b3c97e
https://hg.mozilla.org/mozilla-central/rev/6a900f9ebc76
https://hg.mozilla.org/mozilla-central/rev/f8ae8039c7ad
https://hg.mozilla.org/mozilla-central/rev/e5e7a733fdbc
https://hg.mozilla.org/mozilla-central/rev/77393145e701
https://hg.mozilla.org/mozilla-central/rev/f349334cc957
https://hg.mozilla.org/mozilla-central/rev/f0c671a3cf1d
https://hg.mozilla.org/mozilla-central/rev/19fbefce0e94
https://hg.mozilla.org/mozilla-central/rev/64d71b941c15
https://hg.mozilla.org/mozilla-central/rev/2f3002536fe4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
|
||
Comment 30•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/22d82e970d2a
https://hg.mozilla.org/integration/mozilla-inbound/rev/a25dfd7fbf80
https://hg.mozilla.org/integration/mozilla-inbound/rev/50e1aba59b4b
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e7c8f02b13
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8d85843e8c
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e4064f9e722
https://hg.mozilla.org/integration/mozilla-inbound/rev/89bcf18a1f4d
https://hg.mozilla.org/integration/mozilla-inbound/rev/63704b357cc2
https://hg.mozilla.org/integration/mozilla-inbound/rev/412dcc9441b2
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2a788a54f0b
https://hg.mozilla.org/integration/mozilla-inbound/rev/335658de496d
https://hg.mozilla.org/integration/mozilla-inbound/rev/5061f5987934
https://hg.mozilla.org/integration/mozilla-inbound/rev/5900e08b7d73
|
|
Assignee | |
Comment 31•9 years ago
|
||
Backed out per bug 1191356 comment 23.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Merged backouts:
https://hg.mozilla.org/mozilla-central/rev/22d82e970d2a
https://hg.mozilla.org/mozilla-central/rev/a25dfd7fbf80
https://hg.mozilla.org/mozilla-central/rev/50e1aba59b4b
https://hg.mozilla.org/mozilla-central/rev/f3e7c8f02b13
https://hg.mozilla.org/mozilla-central/rev/8d8d85843e8c
https://hg.mozilla.org/mozilla-central/rev/8e4064f9e722
https://hg.mozilla.org/mozilla-central/rev/89bcf18a1f4d
https://hg.mozilla.org/mozilla-central/rev/63704b357cc2
https://hg.mozilla.org/mozilla-central/rev/412dcc9441b2
https://hg.mozilla.org/mozilla-central/rev/b2a788a54f0b
https://hg.mozilla.org/mozilla-central/rev/335658de496d
https://hg.mozilla.org/mozilla-central/rev/5061f5987934
https://hg.mozilla.org/mozilla-central/rev/5900e08b7d73
Target Milestone: mozilla48 → ---
|
||
Comment 33•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7207f05dd558cd5cde2d354a51f7d04cc800decf
Bug 1190172 part 1 - Clean up nsHTMLEditor::SplitStyleAbovePoint; r=ehsan
|
|
||
Comment 34•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/643bf6006fea9dd538675a8b3e3c0617e84f3d29
Bug 1190172 part 2 - Clean up nsHTMLEditor::ClearStyle; r=ehsan
|
|
||
Comment 35•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac6a27516edb47b4505aeb7d9b28a6607a3ca1b2
Bug 1190172 part 3 - Remove old method variants; r=ehsan
|
|
||
Comment 36•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3a4fcd6e166ce7146bef35760c308edfe9f7817
Bug 1190172 part 4 - Remove unused nsHTMLEditor::HasAttr; r=ehsan
|
|
||
Comment 37•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/aabe14890eb2074a2db9a95f4f1f1168d0efb3a4
Bug 1190172 part 5 - Clean up nsHTMLEditor::NodeIsProperty; r=ehsan
|
|
||
Comment 38•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d9b34db284d62a2557c4e6394705ddceb763224
Bug 1190172 part 6 - Clean up nsHTMLEditor::RelativeFontChangeOnTextNode; r=ehsan
|
|
||
Comment 39•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/47a8205beae7de859c350223bc2caaad51c5f573
Bug 1190172 part 7 - Clean up nsHTMLEditor::PromoteInlineRange; r=ehsan
|
|
||
Comment 40•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d1996e26f78dad15207da2bb1d80ff71bbf9b57
Bug 1190172 part 8 - Clean up nsHTMLEditor::PromoteRangeIfStartsOrEndsInNamedAnchor; r=ehsan
|
|
||
Comment 41•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8af4b2f65a8994534d71923c149bd335075407af
Bug 1190172 part 9 - Clean up nsHTMLEditor::ReturnInHeader; r=ehsan
|
|
||
Comment 42•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd552a08c876d5e2084785f12c96bcc36b810e4f
Bug 1190172 part 10 - Clean up nsHTMLEditor::ReturnInListItem; r=ehsan
|
|
||
Comment 43•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb29532b1b73e1cd5d904e7b7615c840a82b0a8a
Bug 1190172 part 11 - Clean up nsHTMLEditRules::IsEmptyBlock; r=ehsan
|
|
||
Comment 44•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c00c64207d2fa97d2bcf1401019560200b5ad3
Bug 1190172 part 12 - Clean up nsHTMLEditRules::ExpandSelectionForDeletion; r=ehsan
|
|
||
Comment 45•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac42f08543bac98df259996e7e02b86e84b4021f
Backout changeset bb29532b1b73 (bug 1190172 part 11)
https://hg.mozilla.org/integration/mozilla-inbound/rev/f22fa60009f5718f90a5447fccd17f0e7eff276e
Backout changeset fd552a08c876 (bug 1190172 part 10)
https://hg.mozilla.org/integration/mozilla-inbound/rev/0056f4033542ee392659b0a4e1ee3f2403ae2c8a
Backout changeset 8af4b2f65a89 (bug 1190172 part 9)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5e01f5e3813ea70986d53e9f043ac34ce89f874
Backout changeset 6d1996e26f78 (bug 1190172 part 8)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae3969f6fad59beb95c5c80131604ca5b7a02a70
Backout changeset 47a8205beae7 (bug 1190172 part 7)
https://hg.mozilla.org/integration/mozilla-inbound/rev/c02a5a394dba5d35110002e6206726e746a7a3ff
Backout changeset 9d9b34db284d (bug 1190172 part 6)
https://hg.mozilla.org/integration/mozilla-inbound/rev/03fb870d6b0bf38e0243a2e3687ea6cccc949f63
Backout changeset aabe14890eb2 (bug 1190172 part 5)
https://hg.mozilla.org/integration/mozilla-inbound/rev/df7fa82b5fc98269e7f0ce3a798f8caf3c2bd08c
Backout changeset b3a4fcd6e166 (bug 1190172 part 4)
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ac4b785b4a261383488dad7416ad9bff29f1d4
Backout changeset ac6a27516edb (bug 1190172 part 3)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1fc61b9be27e348be8da32d78668ff72d8aed6
Backout changeset 643bf6006fea (bug 1190172 part 2)
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bfcb0917c0921e22ae9d844aa5a5edd12c8e42
Backout changeset 7207f05dd558 (bug 1190172 part 1)
|
|
Assignee | |
Comment 46•9 years ago
|
||
Comment on attachment 8742779 [details] [diff] [review]
Part 1 updated -- Clean up nsHTMLEditor::SplitStyleAbovePoint
Review of attachment 8742779 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/nsHTMLEditorStyle.cpp
@@ +562,2 @@
> {
> + MOZ_ASSERT(aNode && *aNode && aOffset);
This change (NS_ENSURE_TRUE to MOZ_ASSERT) caused bug 1266648, so I'm undoing it before checking in. Since Masayuki is away and I'll leave before he gets back and it's a bit of no-brainer and we want to get this stuff landed already, I'll do it without formally requesting further review.
|
|
||
Comment 47•9 years ago
|
||
|
|
||
Comment 48•9 years ago
|
||
|
|
||
Comment 49•9 years ago
|
||
|
|
||
Comment 50•9 years ago
|
||
|
|
||
Comment 51•9 years ago
|
||
|
|
||
Comment 52•9 years ago
|
||
|
|
||
Comment 53•9 years ago
|
||
|
|
||
Comment 54•9 years ago
|
||
|
|
||
Comment 55•9 years ago
|
||
|
|
||
Comment 56•9 years ago
|
||
|
|
||
Comment 57•9 years ago
|
||
|
|
||
Comment 59•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9c056080ee98
https://hg.mozilla.org/mozilla-central/rev/09235b9b9c4c
https://hg.mozilla.org/mozilla-central/rev/204cbd92cc37
https://hg.mozilla.org/mozilla-central/rev/1ccf786fd04f
https://hg.mozilla.org/mozilla-central/rev/9758cadd473f
https://hg.mozilla.org/mozilla-central/rev/e49523da46b5
https://hg.mozilla.org/mozilla-central/rev/284c3b1d52bf
https://hg.mozilla.org/mozilla-central/rev/cc88a585df5d
https://hg.mozilla.org/mozilla-central/rev/5c3bb21481f7
https://hg.mozilla.org/mozilla-central/rev/6dabbd41ffa2
https://hg.mozilla.org/mozilla-central/rev/66bdae3372ce
https://hg.mozilla.org/mozilla-central/rev/34765a76738e
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•