Clean up nsHTMLEditor::SplitStyleAbovePoint, ClearStyle, NodeIsProperty, RelativeFontChangeOnTextNode, PromoteInlineRange, etc.

RESOLVED FIXED in Firefox 48

Status

()

enhancement
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(12 attachments, 12 obsolete attachments)

13.91 KB, patch
Details | Diff | Splinter Review
8.60 KB, patch
Details | Diff | Splinter Review
7.48 KB, patch
Details | Diff | Splinter Review
2.39 KB, patch
Details | Diff | Splinter Review
4.16 KB, patch
Details | Diff | Splinter Review
15.52 KB, patch
Details | Diff | Splinter Review
9.74 KB, patch
Details | Diff | Splinter Review
7.26 KB, patch
Details | Diff | Splinter Review
8.73 KB, patch
Details | Diff | Splinter Review
17.22 KB, patch
Details | Diff | Splinter Review
6.40 KB, patch
Details | Diff | Splinter Review
13.00 KB, patch
Details | Diff | Splinter Review
No description provided.

Comment 14

4 years ago
Comment on attachment 8643731 [details] [diff] [review]
Part 1 -- Clean up nsHTMLEditor::SplitStyleAbovePoint

Ugh, these patches seem to be megapatches with other unrelated stuff...  They're impossible to review using Splinter.  I'll do some cursory reviews but won't give unimportant nits.  :-)
Attachment #8643731 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643732 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643733 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643734 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643735 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643736 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643737 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643738 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643739 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643742 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643743 - Flags: review?(ehsan) → review+

Updated

4 years ago
Attachment #8643744 - Flags: review?(ehsan) → review+
Attachment #8643732 - Attachment is obsolete: true
Checkin instructions at bug 1191356 comment 20.
Keywords: checkin-needed
Backed out per bug 1191356 comment 23.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac42f08543bac98df259996e7e02b86e84b4021f
Backout changeset bb29532b1b73 (bug 1190172 part 11)

https://hg.mozilla.org/integration/mozilla-inbound/rev/f22fa60009f5718f90a5447fccd17f0e7eff276e
Backout changeset fd552a08c876 (bug 1190172 part 10)

https://hg.mozilla.org/integration/mozilla-inbound/rev/0056f4033542ee392659b0a4e1ee3f2403ae2c8a
Backout changeset 8af4b2f65a89 (bug 1190172 part 9)

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5e01f5e3813ea70986d53e9f043ac34ce89f874
Backout changeset 6d1996e26f78 (bug 1190172 part 8)

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae3969f6fad59beb95c5c80131604ca5b7a02a70
Backout changeset 47a8205beae7 (bug 1190172 part 7)

https://hg.mozilla.org/integration/mozilla-inbound/rev/c02a5a394dba5d35110002e6206726e746a7a3ff
Backout changeset 9d9b34db284d (bug 1190172 part 6)

https://hg.mozilla.org/integration/mozilla-inbound/rev/03fb870d6b0bf38e0243a2e3687ea6cccc949f63
Backout changeset aabe14890eb2 (bug 1190172 part 5)

https://hg.mozilla.org/integration/mozilla-inbound/rev/df7fa82b5fc98269e7f0ce3a798f8caf3c2bd08c
Backout changeset b3a4fcd6e166 (bug 1190172 part 4)

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ac4b785b4a261383488dad7416ad9bff29f1d4
Backout changeset ac6a27516edb (bug 1190172 part 3)

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1fc61b9be27e348be8da32d78668ff72d8aed6
Backout changeset 643bf6006fea (bug 1190172 part 2)

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bfcb0917c0921e22ae9d844aa5a5edd12c8e42
Backout changeset 7207f05dd558 (bug 1190172 part 1)
Comment on attachment 8742779 [details] [diff] [review]
Part 1 updated -- Clean up nsHTMLEditor::SplitStyleAbovePoint

Review of attachment 8742779 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/nsHTMLEditorStyle.cpp
@@ +562,2 @@
>  {
> +  MOZ_ASSERT(aNode && *aNode && aOffset);

This change (NS_ENSURE_TRUE to MOZ_ASSERT) caused bug 1266648, so I'm undoing it before checking in.  Since Masayuki is away and I'll leave before he gets back and it's a bit of no-brainer and we want to get this stuff landed already, I'll do it without formally requesting further review.
You need to log in before you can comment on or make changes to this bug.