Refine appearance of tab audio indicator & enable it by default

VERIFIED FIXED in Firefox 43

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Margaret, Assigned: mcomella)

Tracking

35 Branch
Firefox 43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 verified, relnote-firefox 43+, fennec43+)

Details

Attachments

(9 attachments, 1 obsolete attachment)

Reporter

Description

4 years ago
Let's use this bug to polish the tab audio indicator I built in bug 1018504, since I don't want to block landing those patches on my available free time to work on this :)

Here's a current APK:
http://people.mozilla.org/~mleibovic/tmp/tab-audio.apk

Some outstanding questions:

* Position of tab audio indicator
* Whether or not to allow muting/unmuting (if so, need larger tap area and muted icon)
Flags: needinfo?(alam)
Reporter

Updated

4 years ago
tracking-fennec: --- → ?
I feel like this is a better position for position in tabs tray on Mobile (vertical).

Still to add: tablets.
inline, padded 6 dp from the title :)
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 42+
...and tablets!
Flags: needinfo?(alam)
in the tabs tray, the icon is icon grey (#AFB1B3) with 6 dp padding before the Page title.
Reporter

Comment 6

4 years ago
I like this new tablet design because it will help address the issue of fat-fingering the mute button and accidentally closing the tab. I'll start working on this!

I also commented in bug 1191159 about adding a "muted" icon.
Reporter

Comment 7

4 years ago
Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella
Attachment #8651892 - Flags: review?(michael.l.comella)
Reporter

Comment 8

4 years ago
Bug 1190301 - Enable tab audio indicator by default. r=mcomella
Attachment #8651893 - Flags: review?(michael.l.comella)
Reporter

Comment 9

4 years ago
Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mcomella
Attachment #8651894 - Flags: review?(michael.l.comella)
Reporter

Comment 10

4 years ago
(In reply to :Margaret Leibovic from comment #7)
> Created attachment 8651892 [details]
> MozReview Request: Bug 1190301 - Remove mute button functionality from tab
> audio indicator. r=mcomella
> 
> Bug 1190301 - Remove mute button functionality from tab audio indicator.
> r=mcomella

I did this based on antlam's comments in bug 1191159. I didn't fully flesh out this feature when I landed it, so I'm removing the half-baked code.
Reporter

Comment 11

4 years ago
Comment on attachment 8651892 [details]
MozReview Request: Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella

Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella
Reporter

Comment 12

4 years ago
Comment on attachment 8651893 [details]
MozReview Request: Bug 1190301 - Enable tab audio indicator by default. r=mcomella

Bug 1190301 - Enable tab audio indicator by default. r=mcomella
Reporter

Comment 13

4 years ago
Comment on attachment 8651894 [details]
MozReview Request: Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh

Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh
Attachment #8651894 - Attachment description: MozReview Request: Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mcomella → MozReview Request: Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh
Attachment #8651894 - Flags: review?(michael.l.comella) → review?(mhaigh)
Reporter

Comment 14

4 years ago
Comment on attachment 8651892 [details]
MozReview Request: Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella

Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella
Attachment #8651892 - Flags: review?(michael.l.comella) → review?(mhaigh)
Reporter

Comment 15

4 years ago
Comment on attachment 8651893 [details]
MozReview Request: Bug 1190301 - Enable tab audio indicator by default. r=mcomella

Bug 1190301 - Enable tab audio indicator by default. r=mcomella
Attachment #8651893 - Flags: review?(michael.l.comella) → review?(mhaigh)
Reporter

Comment 16

4 years ago
Posted image phone screenshot (obsolete) —
mcomella told me that mhaigh was planning on removing this layout, so I don't want to stress too much about making it look perfect, but this is what it looks like with this patch.
Reporter

Comment 17

4 years ago
Reporter

Comment 18

4 years ago
Reporter

Updated

4 years ago
Depends on: 1198084
Comment on attachment 8651894 [details]
MozReview Request: Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh

https://reviewboard.mozilla.org/r/17009/#review16025
Attachment #8651894 - Flags: review?(mhaigh) → review+
Comment on attachment 8651892 [details]
MozReview Request: Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella

https://reviewboard.mozilla.org/r/17005/#review16027
Attachment #8651892 - Flags: review?(mhaigh) → review+
Comment on attachment 8651893 [details]
MozReview Request: Bug 1190301 - Enable tab audio indicator by default. r=mcomella

https://reviewboard.mozilla.org/r/17007/#review16029
Attachment #8651893 - Flags: review?(mhaigh) → review+
Taking while Margaret is PTO.
Assignee: margaret.leibovic → michael.l.comella
For this to land, it looks like bug 1198084 needs to land – which is an a11y content description update when playing audio – and to rebase the changes to the tabs panel onto Martyn's latest tabs tray rewrites.
Correction: the implementation of bug 1198084 would change depending on if this bug landed or not, so let's land this first.
Blocks: 1198084
No longer depends on: 1198084
Looks like the new phone tabs tray just worked because it's the same implementation as tablet.
Attachment #8652106 - Attachment is obsolete: true
Oh, two of the commits in comment 26 have the wrong reviewer – it should be mhaigh, not mcomella.
Moving this back to 43, as per bug 1018504 comment 32 and subsequent comments.
tracking-fennec: 42+ → 43+
Summary: Refine appearance of tab audio indicator → Refine appearance of tab audio indicator & enable it by default
Release Note Request (optional, but appreciated)
[Why is this notable]: We can see which tabs are playing audio now!
[Suggested wording]: Display which tabs are playing audio in tab list
[Links (documentation, blog post, etc)]: N/A
relnote-firefox: --- → ?
I think this is close enough to the note for bug 1018504 that I can just combine them into one.

Comment 32

4 years ago
Verified as fixed in Firefox 43 Beta 7;
Devices:
Asus ZenPad 8 (Android 5.0.2);
Nexus 5 (Android 6.0);
Samsung Galaxy R (Android 2.3.4).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.