1190457 - Convert AutoPropertyDescriptorVector to normal Rooted usage

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: auto_propdesc_vec-v1.diff

AutoVector exposes [Mutable]Handle through operator[]. Given that [Mutable]TraceableVectorOperations is only used via Rooted primitives, I think it is safe to add such there as well. Once we do that (and fix up the AutoShapeVector usage), converting from AutoPropertyDescriptorVector to Rooted<TraceableVector<PropertyDescriptor>> is as trivial as changing the names.

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8642498 [details] [diff] [review]
auto_propdesc_vec-v1.diff

Review of attachment 8642498 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: js/public/TraceableVector.h
@@ +96,5 @@
>      T& back() { return vec().back(); }
>  
> +    JS::MutableHandle<T> operator[](size_t aIndex) {
> +        return JS::MutableHandle<T>::fromMarkedLocation(&vec().operator[](aIndex));
> +    }

You may need to add the const version here as well, as per bug 1189722.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30a773d3e4c1

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/30a773d3e4c1