1190693 - Backport bug 1175643 to bmo (Rewrite auth delegation to use a server-side POST instead of a client-side GET to delegate API Key)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

It does what it says on the tin

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1190693_1.patch

and here's the patch

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8642802 [details] [diff] [review]
1190693_1.patch

Review of attachment 8642802 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: auth.cgi
@@ +95,5 @@
> +    $ua->protocols_allowed(['http', 'https']);
> +    # If the URL of the proxy is given, use it, else get this information
> +    # from the environment variable.
> +    my $proxy_url = Bugzilla->params->{'proxy_url'};
> +    if ($proxy_url) {

nit:

if (my $proxy_url = Bugzilla->params->{'proxy_url'}) {
    $ua->proxy(['http', 'https'], $proxy_url);
}
else ...

@@ +112,5 @@
> +        eval {
> +            my $data = decode_json($resp->content);
> +            $callback_uri->query_param(callback_result => $data->{result});
> +        };
> +        if ($@) {

Nit: can shorten to
 
$@ && ThrowUserError('auth_delegation_json_error', { json_text => $resp->content });
print $cgi->redirect($callback_uri);

Comment 3

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   99bec2e..589ec37  master -> master