Closed Bug 1190703 Opened 4 years ago Closed 4 years ago

Assertion failure in ServiceWorkerContainer::Register after NS_NewURI fails

Categories

(Core :: DOM: Service Workers, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jruderman, Assigned: nsm)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
Assertion failure: (((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))), at dom/workers/ServiceWorkerContainer.cpp:136

This assertion is part of code added in https://hg.mozilla.org/mozilla-central/rev/6bcba8fcdafd:

>   // Step 4. If none passed, parse against script's URL
>   if (!aOptions.mScope.WasPassed()) {
>     nsresult rv = NS_NewURI(getter_AddRefs(scopeURI), NS_LITERAL_CSTRING("./"),
>                             nullptr, scriptURI);
> *   MOZ_ALWAYS_TRUE(NS_SUCCEEDED(rv));
Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r?bkelly
Attachment #8643961 - Flags: review?(bkelly)
Comment on attachment 8643961 [details]
MozReview Request: Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r?bkelly

https://reviewboard.mozilla.org/r/15189/#review13613

Ship It!
Attachment #8643961 - Flags: review?(bkelly) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/65767c78adb12f5ff35f7e56b2fe573aba86d85f
changeset:  65767c78adb12f5ff35f7e56b2fe573aba86d85f
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Wed Aug 05 14:33:50 2015 -0700
description:
Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r=bkelly
https://hg.mozilla.org/mozilla-central/rev/65767c78adb1
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.