1190703 - Assertion failure in ServiceWorkerContainer::Register after NS_NewURI fails

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: (((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))), at dom/workers/ServiceWorkerContainer.cpp:136

This assertion is part of code added in https://hg.mozilla.org/mozilla-central/rev/6bcba8fcdafd:

>   // Step 4. If none passed, parse against script's URL
>   if (!aOptions.mScope.WasPassed()) {
>     nsresult rv = NS_NewURI(getter_AddRefs(scopeURI), NS_LITERAL_CSTRING("./"),
>                             nullptr, scriptURI);
> *   MOZ_ALWAYS_TRUE(NS_SUCCEEDED(rv));

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r?bkelly

Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r?bkelly

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

https://reviewboard.mozilla.org/r/15187/#review13611

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8643961 [details]
MozReview Request: Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r?bkelly

https://reviewboard.mozilla.org/r/15189/#review13613

Ship It!

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/65767c78adb12f5ff35f7e56b2fe573aba86d85f
changeset:  65767c78adb12f5ff35f7e56b2fe573aba86d85f
user:       Nikhil Marathe <[e-mail]>
date:       Wed Aug 05 14:33:50 2015 -0700
description:
Bug 1190703 - Relax scope resolution assertion in ServiceWorkerContainer::Register. r=bkelly

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/65767c78adb1